-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TaskAction functionality #5959
Conversation
Two notes:
FWIW the planner agent did well in a manual test a few days ago. Edited to add: it can only be tested manually currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰 (Once Engle's notes are addressed) - But I think we probably need a follow up PR at some point to check our test coverage
Good catch Engel! I think it makes sense to ditch the PlannerAgent for now. We can reintroduce it if we make planning a first-class concept again |
There is this PR in progress, I hope it will allow us a cool alternative way of doing it. |
This PR removes all TaskAction-related code from the codebase, including:
tasks.py
file containingAddTaskAction
andModifyTaskAction
classesopenhands/events/action/__init__.py
openhands/events/serialization/action.py
openhands/controller/agent_controller.py
frontend/src/types/core/actions.ts
tests/unit/test_action_serialization.py
openhands/agenthub/dummy_agent/agent.py
All tests pass and the code has been formatted according to the project standards.
This should fix the issue where main appears to be broken by the command
poetry run python3 openhands/core/main.py -t "do a flip" -d ./workspace/ -c DummyAgent
To run this PR locally, use the following command: