Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resizable and collapsible panel layout #5926

Merged
merged 12 commits into from
Dec 30, 2024
Merged

Add resizable and collapsible panel layout #5926

merged 12 commits into from
Dec 30, 2024

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Dec 30, 2024

Resurrected the resizer component. (This was in place last August)
image

Fixes #5894


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:505e8e0-nikolaik   --name openhands-app-505e8e0   docker.all-hands.dev/all-hands-ai/openhands:505e8e0

@tofarr tofarr marked this pull request as draft December 30, 2024 19:52
@tofarr tofarr marked this pull request as ready for review December 30, 2024 21:13
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, a few notes!

  1. I accidentally did some duplicate work and opened this PR, sorry: Fix issue #5894: Make it possible to collapse the right-hand side of the openhands screen #5896
  2. Overall the code looks nice and it worked in my environment. But It seems to have introduced a regression with respect to the design being reactive to small screen widths. Here's the current one in this PR:
Screenshot 2024-12-31 at 6 38 30 AM

and main for reference:

Screenshot 2024-12-31 at 6 38 46 AM

@tofarr
Copy link
Collaborator Author

tofarr commented Dec 30, 2024

@neubig Responsive design should now work again:
image

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great code-wise, and I confirmed that all the functionality works as expected. Thanks for this, it'll be excellent to have!

@tofarr tofarr enabled auto-merge (squash) December 30, 2024 22:35
@tofarr tofarr merged commit c37e865 into main Dec 30, 2024
16 checks passed
@tofarr tofarr deleted the resizable-panel branch December 30, 2024 22:40
@rbren
Copy link
Collaborator

rbren commented Dec 31, 2024

Not sure what happened here but you can see it in the last screenshot there--there's a style regression here. Going to revert for now

@rbren
Copy link
Collaborator

rbren commented Dec 31, 2024

Screenshot 2024-12-31 at 9 21 19 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to collapse the right-hand side of the openhands screen
4 participants