Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Prevent back tick escape #5897

Merged
merged 1 commit into from
Dec 29, 2024
Merged

[Fix]: Prevent back tick escape #5897

merged 1 commit into from
Dec 29, 2024

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Dec 29, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

There was an issue of the resolver failing with code blocks in the comment body. This occurred because the backtick in the comment body escapes the variable definition in the workflow. This PR makes sure that the escape cannot occur by setting the variable in the ENV.

Here is a sample workflow log


Link of any specific issues this addresses
#5892


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:b092dd7-nikolaik   --name openhands-app-b092dd7   docker.all-hands.dev/all-hands-ai/openhands:b092dd7

@malhotra5 malhotra5 requested review from enyst and neubig December 29, 2024 05:16
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malhotra5 malhotra5 merged commit 2933f07 into main Dec 29, 2024
14 checks passed
@malhotra5 malhotra5 deleted the fix/resolver-escape-bug branch December 29, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants