Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use i18n Keys #5286

Merged
merged 13 commits into from
Dec 30, 2024
Merged

Use i18n Keys #5286

merged 13 commits into from
Dec 30, 2024

Conversation

Vaishakh-SM
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

Right now, several instances of plain English language are used in the codebase. Using i18 keys would ensure better inclusivity by enabling users to use different languages.


Link of any specific issues this addresses

Issue#4280

@Vaishakh-SM Vaishakh-SM mentioned this pull request Nov 26, 2024
@Vaishakh-SM
Copy link
Contributor Author

Vaishakh-SM commented Dec 3, 2024

@amanape , as mentioned here, the tests are failing since I've changed hard-coded alt-text values. Should I update the tests in this PR?

@amanape
Copy link
Member

amanape commented Dec 3, 2024

Feel free to do so. I think I'll be able to resolve the conflicts myself later this week (apparently I should be able to resolve them 😅)

@mamoodi mamoodi requested a review from amanape December 9, 2024 21:08
@neubig
Copy link
Contributor

neubig commented Dec 11, 2024

@amanape , I think OpenHands was able to clean this up, please TAL!

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 23, 2024

@amanape any chance you have a few minutes to review this PR please?

Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM!

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 30, 2024

@Vaishakh-SM just needs a final conflict resolution for merge if you have a few minutes 🙏

@amanape amanape enabled auto-merge (squash) December 30, 2024 15:37
@amanape amanape merged commit 2869d64 into All-Hands-AI:main Dec 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants