Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4931: Make use of microagents configurable in codeact_agent #4932

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Nov 12, 2024

This pull request fixes #4931.

The issue has been successfully resolved. The AI implemented all requested functionality by:

  1. Adding configuration options to customize microagent usage:

    • use_microagents boolean flag to enable/disable all microagents
    • disabled_microagents list to selectively disable specific agents
  2. Making the necessary code changes across multiple files to support these features:

    • Added new config fields to AgentConfig
    • Updated PromptManager to handle disabled agents
    • Modified CodeActAgent to respect these settings
  3. Added comprehensive test coverage to verify the new functionality works as expected

The implementation matches the requested UX requirements and technical implementation suggestions from the original issue. The changes allow users to:

  • Completely disable microagents by setting use_microagents=False
  • Selectively disable specific microagents via disabled_microagents list
  • Maintain default behavior of enabling all microagents when no configuration is provided

All tests are passing, indicating the changes work as intended without breaking existing functionality.

This PR successfully adds the requested customization capabilities while maintaining backward compatibility.

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0b40b51-nikolaik   --name openhands-app-0b40b51   docker.all-hands.dev/all-hands-ai/openhands:0b40b51

@neubig neubig marked this pull request as ready for review November 12, 2024 15:01
@neubig neubig requested a review from enyst November 12, 2024 15:01
Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crushed it, afaict

@neubig neubig enabled auto-merge (squash) November 12, 2024 15:27
@neubig neubig merged commit b54724a into main Nov 12, 2024
12 checks passed
@neubig neubig deleted the openhands-fix-issue-4931 branch November 12, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of microagents configurable in codeact_agent
4 participants