-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate state initialization #6089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! Would it be possible to add a unit test to ensure that this behavior doesn't regress?
@openhands-agent Read the diff of this PR carefully and understand what it does. Then write a unit test for it. Important: you know how to run unit tests in this repo, and you know how to lint python, do it before you finish, so that everything is fine. That is all you need to do, don't do extra stuff. IMPORTANT: do not try to modify the runtime tests, we care only about a new unit test. |
Overview of Changes: Status: All requested changes appear to be fully implemented with no remaining issues. The changes directly address the original requirements through targeted testing of the core functionality. |
32cc1ee
to
87b1956
Compare
End-user friendly description of the problem this fixes or functionality that this introduces
Fix potential issue with loading history twice (the first was empty)
This PR proposes a fix for a duplicate call to
controller.set_initial_state
at the start of an AgentSession.Link of any specific issues this addresses
To run this PR locally, use the following command: