Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eval): Use cp -r instead of mv for SWE-Bench Initialization #5659

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Dec 17, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

For some reason, mv /testbed causes the conda environment to break (most likely because some packages are installed inside docker are based on the absolute path of /testbed)


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:568de64-nikolaik   --name openhands-app-568de64   docker.all-hands.dev/all-hands-ai/openhands:568de64

@xingyaoww xingyaoww requested a review from enyst December 17, 2024 20:50
@xingyaoww
Copy link
Collaborator Author

cc @ryanhoangt

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this, tbh I was idly wondering if mv isn't a bit harsh 👌

@xingyaoww xingyaoww enabled auto-merge (squash) December 17, 2024 21:15
@xingyaoww xingyaoww merged commit 9cdb8d0 into main Dec 17, 2024
13 checks passed
@xingyaoww xingyaoww deleted the xw/fix-swebench-instance branch December 17, 2024 21:21
@ryanhoangt
Copy link
Contributor

ryanhoangt commented Dec 18, 2024

Oh yeah this should also work I think, because we're collecting diff directly in workspace/xxx, thanks! Not sure why I didn't see any issues when running eval in my PR.

Can you help post some error messages here for reference @xingyaoww? Just to trace back when the cp -r might causes some other weird behaviors...

@xingyaoww
Copy link
Collaborator Author

I don't really have specific error messages beside the agent tries to conda install astropy because it fails to run python reproduce.py due to dependency issue 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants