Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Confirmation Mode not working #5608

Closed
1 task done
amirshawn opened this issue Dec 15, 2024 · 8 comments
Closed
1 task done

[Bug]: Confirmation Mode not working #5608

amirshawn opened this issue Dec 15, 2024 · 8 comments
Labels
awaiting release Fixed in main. Waiting for release. bug Something isn't working frontend Related to frontend severity:critical Critical issues or affecting all users

Comments

@amirshawn
Copy link

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

I updated to the newest version of open hands and enabled confirmation mode. I no longer get a prompt to approve an action. It basically gets stuck in the first step. I'm not sure if I'm doing something wrong but previous versions worked as expected.

OpenHands Installation

Development workflow

OpenHands Version

0.15.2

Operating System

MacOS

Logs, Errors, Screenshots, and Additional Context

No response

@amirshawn amirshawn added the bug Something isn't working label Dec 15, 2024
@mamoodi mamoodi added the severity:medium Affecting multiple users label Dec 15, 2024
@amirshawn
Copy link
Author

Not being able to use confirmation mode is making it very difficult to use this system. It goes rogue way too often. Is there a demonstration about how to use open hands with github?

@enyst enyst added the frontend Related to frontend label Dec 19, 2024
@enyst
Copy link
Collaborator

enyst commented Dec 19, 2024

I set this as frontend to begin with, because there doesn't seem to be anything visible in the frontend for the user to Confirm.

@mamoodi mamoodi added severity:critical Critical issues or affecting all users and removed severity:medium Affecting multiple users labels Dec 19, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Dec 19, 2024

Upgrading the severity because it is fully broken.

@amirshawn
Copy link
Author

Thank you @mamoodi one thing I don't quite understand is why we can't toggle confirmation mode on and off without restarting the session? If this can be achieve it definitely should be because using pause still allows the agent to keep doing other things without recognizing the message you sent it in between.

@mamoodi
Copy link
Collaborator

mamoodi commented Dec 22, 2024

@amirshawn yeah that's probably because it gets bundled into "settings" like changing the agent. It shouldn't be necessary. You can open another issue for that if you'd like.

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 28, 2025

This seems fixed in main. Awaiting release.

@mamoodi mamoodi added the awaiting release Fixed in main. Waiting for release. label Jan 28, 2025
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 31, 2025

This is fixed in 0.22. Closing.

@mamoodi mamoodi closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release Fixed in main. Waiting for release. bug Something isn't working frontend Related to frontend severity:critical Critical issues or affecting all users
Projects
None yet
Development

No branches or pull requests

3 participants