Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Github Resolver comment "workflow error" when the workflow is successful #5216

Closed
1 task done
xingyaoww opened this issue Nov 22, 2024 · 4 comments
Closed
1 task done
Labels
bug Something isn't working fix-me Attempt to fix this issue with OpenHands resolver Related to OpenHands Resolver

Comments

@xingyaoww
Copy link
Collaborator

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

Example: #5181 (comment)

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

Error log:

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

@xingyaoww xingyaoww added bug Something isn't working fix-me Attempt to fix this issue with OpenHands labels Nov 22, 2024
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@malhotra5
Copy link
Contributor

malhotra5 commented Nov 22, 2024

I've found one issue which was introduced in this PR

target-branch parameter was added to the Attempt to resolve issue step instead of Create draft PR or push branch step in .github/workflows/openhands-resolver.yml

EDIT: target-branch paramater was introduced in the openhands-ai package which has not been released as of yet. The changes in .github/workflows/openhands-resolver.yml require the unreleased version of openhands-ai

I think there may be one more bug, will keep digging

@enyst
Copy link
Collaborator

enyst commented Nov 25, 2024

The issue I linked looks like a duplicate of this. If you can confirm that, @malhotra5 , I'll just close it.

Example run where it clearly did everything right, just the JSON parsing says it was wrong, apparently:
#5242 (comment)

@mamoodi mamoodi added the resolver Related to OpenHands Resolver label Nov 25, 2024
@malhotra5
Copy link
Contributor

Hmm I don't think its a duplicate. This issue was a more severe case of the resolver failing midway through the workflow, which should be resolved now. Let's close this one and track the JSON decoding issues in #5234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-me Attempt to fix this issue with OpenHands resolver Related to OpenHands Resolver
Projects
None yet
Development

No branches or pull requests

4 participants