-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert camelCase file names to kebab-case #5209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
Nov 24, 2024
enyst
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this style and it's friendly to its python counterpart, FWIW. 😅
wait, it had a name all this time and it was |
amanape
added a commit
that referenced
this pull request
Nov 25, 2024
This was originally added to address the case of case sensitive file changes that were ignored by Git. Details in #5209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
We have a pretty inconsistent file naming convention used throughout the frontend portion of the app.
Give a summary of what the PR does, explaining any non-trivial design decisions
kebab-case
(nice on the eyes, personal preference)Git CI
When working in environments like GitHub CI, file name conflicts arise because Git treats file names as case-insensitive (on case-insensitive file systems like macOS or Windows), while TypeScript treats file names as case-sensitive. This leads to errors when files with mismatched casings are resolved differently in the CI environment, especially on case-sensitive systems like Linux.
To address this, we need to clear both the TypeScript cache and Git cache during the build process.
Follow-up PRs
To run this PR locally, use the following command: