Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert camelCase file names to kebab-case #5209

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Nov 22, 2024

End-user friendly description of the problem this fixes or functionality that this introduces
We have a pretty inconsistent file naming convention used throughout the frontend portion of the app.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Add consistency to all file and directory names to be of kebab-case (nice on the eyes, personal preference)
  • Apply eslint / prettier formats to some components

Git CI

  • Clear TS cache
  • Clear Git cache

When working in environments like GitHub CI, file name conflicts arise because Git treats file names as case-insensitive (on case-insensitive file systems like macOS or Windows), while TypeScript treats file names as case-sensitive. This leads to errors when files with mismatched casings are resolved differently in the CI environment, especially on case-sensitive systems like Linux.

To address this, we need to clear both the TypeScript cache and Git cache during the build process.


Follow-up PRs

  • Remove unused components
  • Merge duplicate components
  • Organize components into folders

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:326815d-nikolaik   --name openhands-app-326815d   docker.all-hands.dev/all-hands-ai/openhands:326815d

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this style and it's friendly to its python counterpart, FWIW. 😅

@peltae
Copy link

peltae commented Nov 24, 2024

wait, it had a name all this time and it was kebab-case? lol

@amanape amanape self-assigned this Nov 25, 2024
@amanape amanape enabled auto-merge (squash) November 25, 2024 06:58
@amanape amanape merged commit 1725627 into main Nov 25, 2024
13 checks passed
@amanape amanape deleted the ALL-725/consistet-file-names branch November 25, 2024 06:59
amanape added a commit that referenced this pull request Nov 25, 2024
This was originally added to address the case of case sensitive file changes that were ignored by Git.

Details in #5209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants