Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for more settings to be set via the settings UI #5094

Open
ryx2 opened this issue Nov 17, 2024 · 7 comments
Open

Allow for more settings to be set via the settings UI #5094

ryx2 opened this issue Nov 17, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@ryx2
Copy link
Contributor

ryx2 commented Nov 17, 2024

What problem or use case are you trying to solve?

I would like more customizability from the settings on the localhost UI.

Describe the UX of the solution you'd like

This settings section
Screenshot 2024-11-17 at 12 30 51 PM

Could very easily fit:

max_iterations
Everything in the LLMConfig (via a file)

Do you have thoughts on the technical implementation?

In the "advanced settings", have max_iterations be a number input, and then also allow to specify a path to a LLMConfig file.

Describe alternatives you've considered

Additional context

@ryx2 ryx2 added the enhancement New feature or request label Nov 17, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Nov 18, 2024

If anyone picks this up, make sure that they join Slack and ask about how we want this implemented in the #frontend channel.
We previously had the settings become complicated and had to spend time simplifying it again.

@diwu-sf
Copy link
Contributor

diwu-sf commented Nov 18, 2024

I feel like Settings should not be a modal, but a whole page with different categories and what not.
It's not long term scalable to jam everything into a fixed size modal

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Dec 19, 2024
@enyst enyst removed the Stale Inactive for 30 days label Dec 19, 2024
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Jan 20, 2025
@enyst enyst removed the Stale Inactive for 30 days label Jan 20, 2025
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 22, 2025

The settings UI will be redesigned at some point.
@rbren just tagging you in case something like this needs to be considered.

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Feb 22, 2025
@enyst
Copy link
Collaborator

enyst commented Feb 22, 2025

The Settings page has been redesigned in #6550, then we are adding another setting. This issue regards next steps when we can perhaps show more options.

@github-actions github-actions bot removed the Stale Inactive for 30 days label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants