Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OpenHands resolver fails to identify issues from new comments #5024

Closed
1 task done
regismesquita opened this issue Nov 15, 2024 · 2 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@regismesquita
Copy link
Contributor

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

I am experiencing issues with the resolver when using it to address a comment in the PR. It seems to disregard my comment and instead follows the original issue. Interestingly, it eventually acknowledges that it did not address the concern raised in the comment.

This is a test issue where I requested a change in a Prometheus metric from 0.1 to 0.100. The project is in Go, and the OpenHands resolver modified the Go version.

OpenHands Installation

Other

OpenHands Version

openhands-resolver@main

Operating System

Linux

Logs, Errors, Screenshots, and Additional Context

The feedback may be addressed to specific code files. In this case the file locations will be provided.
Please update the code based on the feedback for the repository in /workspace.
An environment has been set up for you to start working. You may assume all necessary tools are installed.
# Issues addressed 
[
    "We are currently exporting to prometheus metrics from 0..1 , we want them to be 0..100"
]
# Review comments
None
# Review threads
None
# Review thread files
None
[...]
 12:09:34 - openhands:INFO: resolve_issue.py:210 - **IPythonRunCellAction**
THOUGHT: I'll help fix the issue where the Prometheus metrics need to be scaled from 0..1 to 0..100. Let me first explore the repository to find relevant files that handle Prometheus metrics.
CODE:
print(file_editor(**{'command': 'view', 'path': '/workspace'}))

And by the end:

openhands:ERROR: resolve_issue.py:262 - Failed to parse success_explanation as JSON: The AI agent's response did not address the feedback given in the PR thread comment, which was specifically about removing the .bak file and not changing the Go version. Instead, the agent's response focused on analyzing the metrics ranges, which was from the original issue description.
@regismesquita regismesquita added the bug Something isn't working label Nov 15, 2024
@neubig
Copy link
Contributor

neubig commented Nov 18, 2024

Here is a thread on the OpenHeads github where we were able to reproduce:

@neubig
Copy link
Contributor

neubig commented Nov 25, 2024

Probably fixed by #5115

@neubig neubig closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants