Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Incorporate OpenHands resolver #4963

Closed
neubig opened this issue Nov 13, 2024 · 2 comments
Closed

[Refactor]: Incorporate OpenHands resolver #4963

neubig opened this issue Nov 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@neubig
Copy link
Contributor

neubig commented Nov 13, 2024

The OpenHands resolver evolved as a separate project from OpenHands, but now it has become a somewhat integral form factor for using OpenHands. Because of this, we would like to incorporate the resolver into OpenHands itself. This has a number of benefits:

  1. Preventing updates to OpenHands from breaking the resolver because all the code will be in one place and we can run CI
  2. Allowing for us to incorporate the resolver's actions into OpenHands's listen.py server, which will make it easier logistically to solve https://github.com/All-Hands-AI/openhands-resolver/issues/155 without spinning up a separate server

To solve this issue, we should:

  1. Move all code from the openhands-resolver repo's openhands_resolver into the openhands/resolver directory of the OpenHands repo
  2. Move all tests from the openhands-resolver repo into tests/unit/ in the OpenHands repo
  3. Replace the .github/workflows/openhands-resolver.yml in the OpenHands repo with .github/workflows/openhands-resolver.yml, then make any adjustments to reflect that the resolver will directly use the OpenHands repo
  4. Move documentation from the openhands-resolver repo's README.md into the OpenHands repo's openhands/resolver/README.md.
  5. Adjust the links in the OpenHands documentation web site in the docs directory to point to the OpenHands repo
@neubig neubig added the enhancement New feature or request label Nov 13, 2024
@neubig neubig self-assigned this Nov 13, 2024
@ryx2
Copy link
Contributor

ryx2 commented Nov 15, 2024

Excellent!

@neubig
Copy link
Contributor Author

neubig commented Nov 18, 2024

Done

@neubig neubig closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants