Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Memory-enabled agent #4510

Closed
wants to merge 101 commits into from
Closed

[Experimental] Memory-enabled agent #4510

wants to merge 101 commits into from

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Oct 22, 2024 •
edited
Loading

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR proposes a memory-enabled agent. It integrates the approach implemented by @khushvind and aims to implement a (bit larger) part of a memory system than we have previously:

  • condense messages when necessary / with an experimental option for LLM's choice
  • recall memories
  • use some form of long-term memory - embeddings for recall (llama-index and/or litellm, both available for testing)

Experiment:

  • inspired by the Generative Agents paper and MemGPT paper, it aims to let the agent manage its own memory. Not just us deciding when to re-route stuff to condense, rather have it aware of its memory system and let it decide what is important enough to keep, when and where.

Rough schema of cognitive architecture illustrated among others in Cognitive Architectures for Language Agents:

image

Link of any specific issues this addresses

enyst added 30 commits October 13, 2024 18:39
@enyst
add memory-enabled agent
3775ce2
@enyst
Merge branch 'main' of github.com:All-Hands-AI/OpenHands into memory-…
744be40 
…agent
@enyst
register agent
6f004c8
@enyst
try to use a list of events as history (ATTN will require tricks with…
97ef06f 
… delegates)

fix things

async on_event
@enyst
reset branch, tweak stream.py
21f82e1
@enyst
wip refactor methods
abda3f4
@enyst
move compatibility method to evals
0a7fb43
@enyst
retrieve history in the controller
981335c
@enyst
adapt code to list
1ee26d7
@enyst
add filter by hidden
267f3be
@enyst
remove history.py
9e5659c
@enyst
Merge branch 'main' of github.com:All-Hands-AI/OpenHands into enyst/e…
59c16d4 
…ventstream-state
@enyst
fix types
6fc615f
@enyst
refactoring in evals
3a81363
@enyst
more adaptations in evals
66f78d5
@enyst
rewrite history
1de7b2b
@enyst
actually remove history
adc960f
@enyst
adapt stuck
fac01d1
@enyst
more adaptations
5eb3322
@enyst
fix delegate exclusion
21ede6d
@enyst
create a delegate obs when the delegate ends with an error
5f19a7c
@enyst
Merge branch 'main' of github.com:All-Hands-AI/OpenHands into enyst/e…
526190c 
…ventstream-state
@enyst
fix merge
696f5d1
@enyst
Merge branch 'enyst/eventstream-state' into memory-agent
fccc9f7
@enyst
use event.id in memory, fix merge
611d0e4
@enyst
wip add memory modules
df3f0b6
@enyst
add get_last_user_message
7b0a835
@enyst
Merge branch 'enyst/eventstream-state' into memory-agent
9e1cdcf
@enyst
set user message
34a7b70
@enyst
fix imports
cb60751
enyst added 26 commits October 24, 2024 11:36
@enyst
strange leftover from another branch
6732359
@enyst
tweak agent skill display
ada2ebd
@enyst
add user-defined template directory
1df7aaa
@enyst
Merge branch 'enyst/refactor_template' into enyst/memory-agent
6141d0b
@enyst
ruff
4efcc02
@enyst
fix user prompt; bad coverage
6f282b9
@enyst
Merge branch 'enyst/refactor_template' into enyst/memory-agent
274ad61
@enyst
Merge branch 'main' of github.com:All-Hands-AI/OpenHands into enyst/e…
ad0b9b2 
…ventstream-state
@enyst
save events as they happen
11d82f2
@enyst
clean up obsolete config var - sessions are always saved if filestore…
54f60ac 
… is appropriate
@enyst
Merge branch 'enyst/eventstream-state' into enyst/memory-agent
d4d3aa0
@enyst
Merge branch 'main' of github.com:All-Hands-AI/OpenHands into enyst/e…
99a257c 
…ventstream-state
@enyst
init history for restored state
c6a9028
@enyst
not worth caching delegates if only used once or twice per session
9af6e5e
@enyst
init history from the event stream
04b6d70
@enyst
remove script that got here by accident
34e0f8a
@enyst
save/restore state automatically
94c68be
@enyst
tweak init/restore
93cfd32
@enyst
Merge branch 'main' of github.com:All-Hands-AI/OpenHands into enyst/e…
cfc158d 
…ventstream-state
@enyst
set delegates start explicitly; minor tweaks
f53e1cf
@enyst
fix tests
f42cbed
@enyst
clean up verbose log
ebeab75
@enyst
make extra sure we have a valid start
a213c65
@enyst
Merge branch 'enyst/eventstream-state' into enyst/memory-agent
41c03ad
@enyst
poetry lock
63284d3
@enyst
update summarize prompt
4d05ab1
@mamoodi
Copy link
Collaborator

mamoodi commented Nov 25, 2024

Hi @enyst. Just pinging you regarding this PR. Looks like a lot of changes and conflicts but hasn't had commits in a while. Is this something you will be pursuing still?

@enyst enyst self-assigned this Nov 27, 2024
@enyst
Copy link
Collaborator Author

enyst commented Dec 2, 2024

Hi @enyst. Just pinging you regarding this PR. Looks like a lot of changes and conflicts but hasn't had commits in a while. Is this something you will be pursuing still?

Thanks for the ping, and sorry for the time taken. I'll go about this differently. 😅

@enyst enyst closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enyst enyst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enyst @mamoodi @khushvind