Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the frontend to use i18n keys #4280

Closed
amanape opened this issue Oct 8, 2024 · 7 comments · Fixed by #6070
Closed

Update the frontend to use i18n keys #4280

amanape opened this issue Oct 8, 2024 · 7 comments · Fixed by #6070
Assignees
Labels
enhancement New feature or request frontend Related to frontend good first issue Good for newcomers large effort Estimated large effort

Comments

@amanape
Copy link
Member

amanape commented Oct 8, 2024

What problem or use case are you trying to solve?
The new UI hardcodes english text throughout the app. In order to support i18n, we should extend our i18n provider and replaced the hardcoded values with the new keys

Describe the UX of the solution you'd like

Do you have thoughts on the technical implementation?

Describe alternatives you've considered

Additional context

@amanape amanape added enhancement New feature or request good first issue Good for newcomers frontend Related to frontend large effort Estimated large effort labels Oct 8, 2024
@Vaishakh-SM
Copy link
Contributor

Vaishakh-SM commented Oct 9, 2024

Went through the codebase and got a good understanding of the changes that I would need to make here. Can I work on this?

Also what are your thoughts on adding eslint-plugin-i18n to give warnings so that we do not miss out on this in the future?

@amanape
Copy link
Member Author

amanape commented Oct 9, 2024

Thanks for taking this up @Vaishakh-SM, feel free to open a PR with the changes when you're ready.

As for eslint-plugin-i18n, I'm not familiar with this library and it looks to only support a small set of languages. Additionally, we are unlikely to be able to implement all required translations at once, so adding eslint-plugin-i18n may be a source of annoyance too.

@Vaishakh-SM
Copy link
Contributor

Vaishakh-SM commented Oct 10, 2024

Checklist:

  • Audit: Understand necessary code changes.
  • Update one file: Replace hardcoded values with i18n keys and get a review.
  • Identification: Identify all places that need the change
  • Apply to all files: Extend the changes across the remaining files.
  • Test: Verify i18n works for different languages.
  • Address feedback: Implement any review suggestions.
  • Final review and merge: Ensure all tests pass and merge the PR.

@danicruz0415
Copy link
Contributor

Hey! I can assist with the i18n process if you want 💪

@Vaishakh-SM
Copy link
Contributor

Hi @danicruz0415 !

Yea that'll be great. I've raised a PR where I've made changes to a single file. If that seems good we could start making changes to the entire repo.

@danicruz0415 danicruz0415 mentioned this issue Oct 18, 2024
26 tasks
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Nov 23, 2024
@amanape amanape removed the Stale Inactive for 30 days label Nov 23, 2024
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 30 days label Dec 30, 2024
@amanape amanape removed the Stale Inactive for 30 days label Dec 30, 2024
@neubig neubig assigned neubig and unassigned Vaishakh-SM Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend good first issue Good for newcomers large effort Estimated large effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants