Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Import Project" doesn't allow opening of a directory #4255

Closed
2 tasks done
neubig opened this issue Oct 7, 2024 · 5 comments · Fixed by #4515
Closed
2 tasks done

[Bug]: "Import Project" doesn't allow opening of a directory #4255

neubig opened this issue Oct 7, 2024 · 5 comments · Fixed by #4515
Assignees
Labels
backend Related to backend bug Something isn't working frontend Related to frontend

Comments

@neubig
Copy link
Contributor

neubig commented Oct 7, 2024

Is there an existing issue for the same bug?

Describe the bug

I clicked on the "import project" button on the new UI.

Screenshot 2024-10-07 at 4 32 47 PM

When I clicked on this I expected that it would allow me to open a directory that I could use as the workspace, but in the mac file selection menu it doesn't allow me to open a directory (the "Open" button is inactive when I select a directory).

Screenshot 2024-10-07 at 4 31 41 PM

Current OpenHands version

0809d26f4d8a5514c0a255ed0a3bf3d999b1c29f

Installation and Configuration

make build; make run

Model and Agent

No response

Operating System

No response

Reproduction Steps

No response

Logs, Errors, Screenshots, and Additional Context

No response

@neubig neubig added bug Something isn't working frontend Related to frontend labels Oct 7, 2024
@mamoodi
Copy link
Collaborator

mamoodi commented Oct 7, 2024

@amanape has mentioned this only works with .zip files. Have to decide whether to make this more clear or to allow directories to be selected.

@neubig
Copy link
Contributor Author

neubig commented Oct 7, 2024

Oh, when this is running locally I just assumed it would set the workspace directory. It seems like a nicer solution than requiring a zip file

@amanape
Copy link
Member

amanape commented Oct 14, 2024

We'd probably have to zip the directory either way when doing so, seems a matter of extending functionality. There doesn't seem to be any downsides I can think of, I'm good with the idea.

@rbren Thoughts?

@amanape amanape added the backend Related to backend label Oct 14, 2024
@rbren
Copy link
Collaborator

rbren commented Oct 14, 2024

This seems to have reasonable support in desktop browsers: https://caniuse.com/input-file-directory

We will probably have to handle it as a multipart upload, if I had to guess...not great but doable

@xingyaoww
Copy link
Collaborator

Or we could allow user to select a "folder" - and automatically zipping that folder for upload if we are using it on saas, otherwise just set that as workspace (in case it is launched locally?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend bug Something isn't working frontend Related to frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants