From 707cb07f4fe85bcc29c4313f70f868b8c3a10d59 Mon Sep 17 00:00:00 2001
From: tofarr <tofarr@gmail.com>
Date: Mon, 10 Feb 2025 12:34:58 +0000
Subject: [PATCH] Removed in page callback (#6657)

---
 .../settings/account-settings-modal.test.tsx  |  1 +
 frontend/src/context/auth-context.tsx         | 10 ++++-
 frontend/src/hooks/query/use-settings.ts      |  8 ----
 frontend/src/routes.ts                        |  2 -
 frontend/src/routes/oauth.github.callback.tsx | 39 -------------------
 frontend/test-utils.tsx                       |  2 +-
 6 files changed, 10 insertions(+), 52 deletions(-)
 delete mode 100644 frontend/src/routes/oauth.github.callback.tsx

diff --git a/frontend/__tests__/components/modals/settings/account-settings-modal.test.tsx b/frontend/__tests__/components/modals/settings/account-settings-modal.test.tsx
index 8e1b236722d1..2291b0af5d74 100644
--- a/frontend/__tests__/components/modals/settings/account-settings-modal.test.tsx
+++ b/frontend/__tests__/components/modals/settings/account-settings-modal.test.tsx
@@ -132,6 +132,7 @@ describe("AccountSettingsModal", () => {
       agent: "CodeActAgent",
       confirmation_mode: false,
       enable_default_condenser: false,
+      github_token: undefined,
       language: "en",
       llm_base_url: "",
       llm_model: "anthropic/claude-3-5-sonnet-20241022",
diff --git a/frontend/src/context/auth-context.tsx b/frontend/src/context/auth-context.tsx
index e7aed7b0d4d5..3e42759b9e4b 100644
--- a/frontend/src/context/auth-context.tsx
+++ b/frontend/src/context/auth-context.tsx
@@ -5,10 +5,16 @@ interface AuthContextType {
   setGitHubTokenIsSet: (value: boolean) => void;
 }
 
+interface AuthContextProps extends React.PropsWithChildren {
+  initialGithubTokenIsSet?: boolean;
+}
+
 const AuthContext = React.createContext<AuthContextType | undefined>(undefined);
 
-function AuthProvider({ children }: React.PropsWithChildren) {
-  const [githubTokenIsSet, setGitHubTokenIsSet] = React.useState(false);
+function AuthProvider({ children, initialGithubTokenIsSet }: AuthContextProps) {
+  const [githubTokenIsSet, setGitHubTokenIsSet] = React.useState(
+    !!initialGithubTokenIsSet,
+  );
 
   const value = React.useMemo(
     () => ({
diff --git a/frontend/src/hooks/query/use-settings.ts b/frontend/src/hooks/query/use-settings.ts
index 107a91c6926b..f47240e382ed 100644
--- a/frontend/src/hooks/query/use-settings.ts
+++ b/frontend/src/hooks/query/use-settings.ts
@@ -50,13 +50,5 @@ export const useSettings = () => {
     setGitHubTokenIsSet(!!query.data?.GITHUB_TOKEN_IS_SET);
   }, [query.data?.GITHUB_TOKEN_IS_SET, query.isFetched]);
 
-  // Return default settings if in SAAS mode and not authenticated
-  if (config?.APP_MODE === "saas" && !githubTokenIsSet) {
-    return {
-      ...query,
-      data: DEFAULT_SETTINGS,
-    };
-  }
-
   return query;
 };
diff --git a/frontend/src/routes.ts b/frontend/src/routes.ts
index 53305537a0b8..f71299887783 100644
--- a/frontend/src/routes.ts
+++ b/frontend/src/routes.ts
@@ -15,6 +15,4 @@ export default [
       route("served", "routes/app.tsx"),
     ]),
   ]),
-
-  route("oauth/github/callback", "routes/oauth.github.callback.tsx"),
 ] satisfies RouteConfig;
diff --git a/frontend/src/routes/oauth.github.callback.tsx b/frontend/src/routes/oauth.github.callback.tsx
deleted file mode 100644
index f10fcf23e6e2..000000000000
--- a/frontend/src/routes/oauth.github.callback.tsx
+++ /dev/null
@@ -1,39 +0,0 @@
-import { useNavigate, useSearchParams } from "react-router";
-import { useQuery } from "@tanstack/react-query";
-import React from "react";
-import OpenHands from "#/api/open-hands";
-
-function OAuthGitHubCallback() {
-  const navigate = useNavigate();
-  const [searchParams] = useSearchParams();
-  const code = searchParams.get("code");
-
-  const { isSuccess, error } = useQuery({
-    queryKey: ["access_token", code],
-    queryFn: () => OpenHands.getGitHubAccessToken(code!),
-    enabled: !!code,
-  });
-
-  React.useEffect(() => {
-    if (isSuccess) {
-      navigate("/");
-    }
-  }, [isSuccess]);
-
-  if (error) {
-    return (
-      <div>
-        <h1>Error</h1>
-        <p>{error.message}</p>
-      </div>
-    );
-  }
-
-  return (
-    <div>
-      <h1>Redirecting...</h1>
-    </div>
-  );
-}
-
-export default OAuthGitHubCallback;
diff --git a/frontend/test-utils.tsx b/frontend/test-utils.tsx
index 42bd9ec6e0d9..d39ced887a39 100644
--- a/frontend/test-utils.tsx
+++ b/frontend/test-utils.tsx
@@ -66,7 +66,7 @@ export function renderWithProviders(
   function Wrapper({ children }: PropsWithChildren) {
     return (
       <Provider store={store}>
-        <AuthProvider>
+        <AuthProvider initialGithubTokenIsSet={true}>
           <QueryClientProvider
             client={
               new QueryClient({