MacOS
- ### Docker Desktop + + **Docker Desktop** 1. [Install Docker Desktop on Mac](https://docs.docker.com/desktop/setup/install/mac-install). 2. Open Docker Desktop, go to `Settings > Advanced` and ensure `Allow the default Docker socket to be used` is enabled. @@ -25,7 +26,7 @@ A system with a modern processor and a minimum of **4GB RAM** is recommended to Tested with Ubuntu 22.04. ::: - ### Docker Desktop + **Docker Desktop** 1. [Install Docker Desktop on Linux](https://docs.docker.com/desktop/setup/install/linux/). @@ -33,12 +34,13 @@ A system with a modern processor and a minimum of **4GB RAM** is recommended toWindows
- ### WSL + + **WSL** 1. [Install WSL](https://learn.microsoft.com/en-us/windows/wsl/install). 2. Run `wsl --version` in powershell and confirm `Default Version: 2`. - ### Docker Desktop + **Docker Desktop** 1. [Install Docker Desktop on Windows](https://docs.docker.com/desktop/setup/install/windows-install). 2. Open Docker Desktop, go to `Settings` and confirm the following: @@ -56,17 +58,17 @@ A system with a modern processor and a minimum of **4GB RAM** is recommended to The easiest way to run OpenHands is in Docker. ```bash -docker pull docker.all-hands.dev/all-hands-ai/runtime:0.24-nikolaik +docker pull docker.all-hands.dev/all-hands-ai/runtime:0.25-nikolaik docker run -it --rm --pull=always \ - -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0.24-nikolaik \ + -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0.25-nikolaik \ -e LOG_ALL_EVENTS=true \ -v /var/run/docker.sock:/var/run/docker.sock \ -v ~/.openhands-state:/.openhands-state \ -p 3000:3000 \ --add-host host.docker.internal:host-gateway \ --name openhands-app \ - docker.all-hands.dev/all-hands-ai/openhands:0.24 + docker.all-hands.dev/all-hands-ai/openhands:0.25 ``` You'll find OpenHands running at http://localhost:3000! @@ -78,24 +80,22 @@ or run it on tagged issues with [a github action](https://docs.all-hands.dev/mod ## Setup -Upon launching OpenHands, you'll see a settings modal. You **must** select an `LLM Provider` and `LLM Model` and enter a corresponding `API Key`. +Upon launching OpenHands, you'll see a Settings page. You **must** select an `LLM Provider` and `LLM Model` and enter a corresponding `API Key`. These can be changed at any time by selecting the `Settings` button (gear icon) in the UI. -If the required `LLM Model` does not exist in the list, you can toggle `Advanced Options` and manually enter it with the correct prefix +If the required model does not exist in the list, you can toggle `Advanced` options and manually enter it with the correct prefix in the `Custom Model` text box. -The `Advanced Options` also allow you to specify a `Base URL` if required. +The `Advanced` options also allow you to specify a `Base URL` if required. -
- 
- 
-
+Now you're ready to [get started with OpenHands](./getting-started).
## Versions
-The command above pulls the most recent stable release of OpenHands. You have other options as well:
-- For a specific release, use `docker.all-hands.dev/all-hands-ai/openhands:$VERSION`, replacing $VERSION with the version number.
-- We use semver, and release major, minor, and patch tags. So `0.9` will automatically point to the latest `0.9.x` release, and `0` will point to the latest `0.x.x` release.
-- For the most up-to-date development version, you can use `docker.all-hands.dev/all-hands-ai/openhands:main`. This version is unstable and is recommended for testing or development purposes only.
+The [docker command above](./installation#start-the-app) pulls the most recent stable release of OpenHands. You have other options as well:
+- For a specific release, replace $VERSION in `openhands:$VERSION` and `runtime:$VERSION`, with the version number.
+We use SemVer so `0.9` will automatically point to the latest `0.9.x` release, and `0` will point to the latest `0.x.x` release.
+- For the most up-to-date development version, replace $VERSION in `openhands:$VERSION` and `runtime:$VERSION`, with `main`.
+This version is unstable and is recommended for testing or development purposes only.
You can choose the tag that best suits your needs based on stability requirements and desired features.
diff --git a/docs/modules/usage/llms/azure-llms.md b/docs/modules/usage/llms/azure-llms.md
index 7046fe7bf536..84f16627ab31 100644
--- a/docs/modules/usage/llms/azure-llms.md
+++ b/docs/modules/usage/llms/azure-llms.md
@@ -25,7 +25,7 @@ You will need your ChatGPT deployment name which can be found on the deployments
<deployment-name> below.
:::
-1. Enable `Advanced Options`
+1. Enable `Advanced` options
2. Set the following:
- `Custom Model` to azure/<deployment-name>
- `Base URL` to your Azure API Base URL (e.g. `https://example-endpoint.openai.azure.com`)
diff --git a/docs/modules/usage/llms/google-llms.md b/docs/modules/usage/llms/google-llms.md
index d89ba389f057..74e9015ffb0a 100644
--- a/docs/modules/usage/llms/google-llms.md
+++ b/docs/modules/usage/llms/google-llms.md
@@ -10,7 +10,7 @@ OpenHands uses LiteLLM to make calls to Google's chat models. You can find their
When running OpenHands, you'll need to set the following in the OpenHands UI through the Settings:
- `LLM Provider` to `Gemini`
- `LLM Model` to the model you will be using.
-If the model is not in the list, toggle `Advanced Options`, and enter it in `Custom Model` (e.g. gemini/<model-name> like `gemini/gemini-1.5-pro`).
+If the model is not in the list, toggle `Advanced` options, and enter it in `Custom Model` (e.g. gemini/<model-name> like `gemini/gemini-1.5-pro`).
- `API Key` to your Gemini API key
## VertexAI - Google Cloud Platform Configs
@@ -27,4 +27,4 @@ VERTEXAI_LOCATION="
-
-
+
+
);
}
diff --git a/docs/static/img/settings-advanced.png b/docs/static/img/settings-advanced.png
deleted file mode 100644
index 43a9cf05ab83..000000000000
Binary files a/docs/static/img/settings-advanced.png and /dev/null differ
diff --git a/docs/static/img/settings-screenshot.png b/docs/static/img/settings-screenshot.png
deleted file mode 100644
index 987dd8c25570..000000000000
Binary files a/docs/static/img/settings-screenshot.png and /dev/null differ
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
index f03e27c271f6..12eb28118046 100644
--- a/frontend/package-lock.json
+++ b/frontend/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "openhands-frontend",
- "version": "0.24.0",
+ "version": "0.25.0",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "openhands-frontend",
- "version": "0.24.0",
+ "version": "0.25.0",
"dependencies": {
"@heroui/react": "2.6.14",
"@monaco-editor/react": "^4.7.0-rc.0",
diff --git a/frontend/package.json b/frontend/package.json
index b840a3e51418..4fc89d93629d 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -1,6 +1,6 @@
{
"name": "openhands-frontend",
- "version": "0.24.0",
+ "version": "0.25.0",
"private": true,
"type": "module",
"engines": {
diff --git a/openhands/agenthub/dummy_agent/agent.py b/openhands/agenthub/dummy_agent/agent.py
index f7a654bf75b4..b420a3d5d8ae 100644
--- a/openhands/agenthub/dummy_agent/agent.py
+++ b/openhands/agenthub/dummy_agent/agent.py
@@ -22,7 +22,6 @@
CmdOutputObservation,
FileReadObservation,
FileWriteObservation,
- NullObservation,
Observation,
)
from openhands.events.serialization.event import event_to_dict
@@ -109,7 +108,7 @@ def __init__(self, llm: LLM, config: AgentConfig):
},
{
'action': AgentRejectAction(),
- 'observations': [NullObservation('')],
+ 'observations': [AgentStateChangedObservation('', AgentState.REJECTED)],
},
{
'action': AgentFinishAction(
diff --git a/openhands/agenthub/micro/agent.py b/openhands/agenthub/micro/agent.py
index 2c22e3840a51..37de035c461d 100644
--- a/openhands/agenthub/micro/agent.py
+++ b/openhands/agenthub/micro/agent.py
@@ -6,11 +6,11 @@
from openhands.controller.state.state import State
from openhands.core.config import AgentConfig
from openhands.core.message import ImageContent, Message, TextContent
-from openhands.core.utils import json
from openhands.events.action import Action
from openhands.events.event import Event
from openhands.events.serialization.action import action_from_dict
from openhands.events.serialization.event import event_to_memory
+from openhands.io import json
from openhands.llm.llm import LLM
diff --git a/openhands/core/cli.py b/openhands/core/cli.py
index 1e31537155ac..05a390d8b815 100644
--- a/openhands/core/cli.py
+++ b/openhands/core/cli.py
@@ -29,8 +29,8 @@
AgentStateChangedObservation,
CmdOutputObservation,
FileEditObservation,
- NullObservation,
)
+from openhands.io import read_input, read_task
def display_message(message: str):
@@ -83,21 +83,6 @@ def display_event(event: Event, config: AppConfig):
display_confirmation(event.confirmation_state)
-def read_input(config: AppConfig) -> str:
- """Read input from user based on config settings."""
- if config.cli_multiline_input:
- print('Enter your message (enter "/exit" on a new line to finish):')
- lines = []
- while True:
- line = input('>> ').rstrip()
- if line == '/exit': # finish input
- break
- lines.append(line)
- return '\n'.join(lines)
- else:
- return input('>> ').rstrip()
-
-
async def main(loop: asyncio.AbstractEventLoop):
"""Runs the agent in CLI mode."""
@@ -105,7 +90,14 @@ async def main(loop: asyncio.AbstractEventLoop):
logger.setLevel(logging.WARNING)
- config = setup_config_from_args(args)
+ # Load config from toml and override with command line arguments
+ config: AppConfig = setup_config_from_args(args)
+
+ # Read task from file, CLI args, or stdin
+ task_str = read_task(args, config.cli_multiline_input)
+
+ # If we have a task, create initial user action
+ initial_user_action = MessageAction(content=task_str) if task_str else None
sid = str(uuid4())
@@ -118,7 +110,9 @@ async def main(loop: asyncio.AbstractEventLoop):
async def prompt_for_next_task():
# Run input() in a thread pool to avoid blocking the event loop
- next_message = await loop.run_in_executor(None, read_input, config)
+ next_message = await loop.run_in_executor(
+ None, read_input, config.cli_multiline_input
+ )
if not next_message.strip():
await prompt_for_next_task()
if next_message == 'exit':
@@ -143,19 +137,18 @@ async def on_event_async(event: Event):
AgentState.FINISHED,
]:
await prompt_for_next_task()
- if (
- isinstance(event, NullObservation)
- and controller.state.agent_state == AgentState.AWAITING_USER_CONFIRMATION
- ):
- user_confirmed = await prompt_for_user_confirmation()
- if user_confirmed:
- event_stream.add_event(
- ChangeAgentStateAction(AgentState.USER_CONFIRMED), EventSource.USER
- )
- else:
- event_stream.add_event(
- ChangeAgentStateAction(AgentState.USER_REJECTED), EventSource.USER
- )
+ if event.agent_state == AgentState.AWAITING_USER_CONFIRMATION:
+ user_confirmed = await prompt_for_user_confirmation()
+ if user_confirmed:
+ event_stream.add_event(
+ ChangeAgentStateAction(AgentState.USER_CONFIRMED),
+ EventSource.USER,
+ )
+ else:
+ event_stream.add_event(
+ ChangeAgentStateAction(AgentState.USER_REJECTED),
+ EventSource.USER,
+ )
def on_event(event: Event) -> None:
loop.create_task(on_event_async(event))
@@ -164,7 +157,12 @@ def on_event(event: Event) -> None:
await runtime.connect()
- asyncio.create_task(prompt_for_next_task())
+ if initial_user_action:
+ # If there's an initial user action, enqueue it and do not prompt again
+ event_stream.add_event(initial_user_action, EventSource.USER)
+ else:
+ # Otherwise prompt for the user's first message right away
+ asyncio.create_task(prompt_for_next_task())
await run_agent_until_done(
controller, runtime, [AgentState.STOPPED, AgentState.ERROR]
diff --git a/openhands/core/config/llm_config.py b/openhands/core/config/llm_config.py
index cee22766df14..5497d7125823 100644
--- a/openhands/core/config/llm_config.py
+++ b/openhands/core/config/llm_config.py
@@ -102,3 +102,9 @@ def model_post_init(self, __context: Any):
os.environ['OR_SITE_URL'] = self.openrouter_site_url
if self.openrouter_app_name:
os.environ['OR_APP_NAME'] = self.openrouter_app_name
+
+ # Assign an API version for Azure models
+ # While it doesn't seem required, the format supported by the API without version seems old and will likely break.
+ # Azure issue: https://github.com/All-Hands-AI/OpenHands/issues/6777
+ if self.model.startswith('azure') and self.api_version is None:
+ self.api_version = '2024-08-01-preview'
diff --git a/openhands/core/main.py b/openhands/core/main.py
index 2652931cce7a..12e0c4e7876c 100644
--- a/openhands/core/main.py
+++ b/openhands/core/main.py
@@ -1,7 +1,6 @@
import asyncio
import json
import os
-import sys
from pathlib import Path
from typing import Callable, Protocol
@@ -29,6 +28,7 @@
from openhands.events.observation import AgentStateChangedObservation
from openhands.events.serialization import event_from_dict
from openhands.events.serialization.event import event_to_trajectory
+from openhands.io import read_input, read_task
from openhands.runtime.base import Runtime
@@ -41,32 +41,6 @@ def __call__(
) -> str: ...
-def read_task_from_file(file_path: str) -> str:
- """Read task from the specified file."""
- with open(file_path, 'r', encoding='utf-8') as file:
- return file.read()
-
-
-def read_task_from_stdin() -> str:
- """Read task from stdin."""
- return sys.stdin.read()
-
-
-def read_input(config: AppConfig) -> str:
- """Read input from user based on config settings."""
- if config.cli_multiline_input:
- print('Enter your message (enter "/exit" on a new line to finish):')
- lines = []
- while True:
- line = input('>> ').rstrip()
- if line == '/exit': # finish input
- break
- lines.append(line)
- return '\n'.join(lines)
- else:
- return input('>> ').rstrip()
-
-
async def run_controller(
config: AppConfig,
initial_user_action: Action,
@@ -139,7 +113,6 @@ async def run_controller(
assert isinstance(
initial_user_action, Action
), f'initial user actions must be an Action, got {type(initial_user_action)}'
- # Logging
logger.debug(
f'Agent Controller Initialized: Running agent {agent.name}, model '
f'{agent.llm.config.model}, with actions: {initial_user_action}'
@@ -167,7 +140,7 @@ def on_event(event: Event):
if exit_on_message:
message = '/exit'
elif fake_user_response_fn is None:
- message = read_input(config)
+ message = read_input(config.cli_multiline_input)
else:
message = fake_user_response_fn(controller.get_state())
action = MessageAction(content=message)
@@ -268,28 +241,23 @@ def load_replay_log(trajectory_path: str) -> tuple[list[Event] | None, Action]:
if __name__ == '__main__':
args = parse_arguments()
- config = setup_config_from_args(args)
+ config: AppConfig = setup_config_from_args(args)
- # Determine the task
- task_str = ''
- if args.file:
- task_str = read_task_from_file(args.file)
- elif args.task:
- task_str = args.task
- elif not sys.stdin.isatty():
- task_str = read_task_from_stdin()
+ # Read task from file, CLI args, or stdin
+ task_str = read_task(args, config.cli_multiline_input)
- initial_user_action: Action = NullAction()
if config.replay_trajectory_path:
if task_str:
raise ValueError(
'User-specified task is not supported under trajectory replay mode'
)
- elif task_str:
- initial_user_action = MessageAction(content=task_str)
- else:
+
+ if not task_str:
raise ValueError('No task provided. Please specify a task through -t, -f.')
+ # Create initial user action
+ initial_user_action: MessageAction = MessageAction(content=task_str)
+
# Set session name
session_name = args.name
sid = generate_sid(config, session_name)
diff --git a/openhands/core/utils/__init__.py b/openhands/core/utils/__init__.py
deleted file mode 100644
index e69de29bb2d1..000000000000
diff --git a/openhands/events/stream.py b/openhands/events/stream.py
index 0fc547803f6d..938269822a7a 100644
--- a/openhands/events/stream.py
+++ b/openhands/events/stream.py
@@ -8,9 +8,9 @@
from typing import Callable, Iterable
from openhands.core.logger import openhands_logger as logger
-from openhands.core.utils import json
from openhands.events.event import Event, EventSource
from openhands.events.serialization.event import event_from_dict, event_to_dict
+from openhands.io import json
from openhands.storage import FileStore
from openhands.storage.locations import (
get_conversation_dir,
diff --git a/openhands/events/utils.py b/openhands/events/utils.py
index bf710edcd7bd..cfc2dd804c3a 100644
--- a/openhands/events/utils.py
+++ b/openhands/events/utils.py
@@ -10,7 +10,9 @@
def get_pairs_from_events(events: list[Event]) -> list[tuple[Action, Observation]]:
- """Return the history as a list of tuples (action, observation)."""
+ """Return the history as a list of tuples (action, observation).
+
+ This function is a compatibility function for evals reading and visualization working with old histories."""
tuples: list[tuple[Action, Observation]] = []
action_map: dict[int, Action] = {}
observation_map: dict[int, Observation] = {}
diff --git a/openhands/io/__init__.py b/openhands/io/__init__.py
new file mode 100644
index 000000000000..bf1a054356c1
--- /dev/null
+++ b/openhands/io/__init__.py
@@ -0,0 +1,10 @@
+from openhands.io.io import read_input, read_task, read_task_from_file
+from openhands.io.json import dumps, loads
+
+__all__ = [
+ 'read_input',
+ 'read_task_from_file',
+ 'read_task',
+ 'dumps',
+ 'loads',
+]
diff --git a/openhands/io/io.py b/openhands/io/io.py
new file mode 100644
index 000000000000..2e42df912b77
--- /dev/null
+++ b/openhands/io/io.py
@@ -0,0 +1,40 @@
+import argparse
+import sys
+
+
+def read_input(cli_multiline_input: bool = False) -> str:
+ """Read input from user based on config settings."""
+ if cli_multiline_input:
+ print('Enter your message (enter "/exit" on a new line to finish):')
+ lines = []
+ while True:
+ line = input('>> ').rstrip()
+ if line == '/exit': # finish input
+ break
+ lines.append(line)
+ return '\n'.join(lines)
+ else:
+ return input('>> ').rstrip()
+
+
+def read_task_from_file(file_path: str) -> str:
+ """Read task from the specified file."""
+ with open(file_path, 'r', encoding='utf-8') as file:
+ return file.read()
+
+
+def read_task(args: argparse.Namespace, cli_multiline_input: bool) -> str:
+ """
+ Read the task from the CLI args, file, or stdin.
+ """
+
+ # Determine the task
+ task_str = ''
+ if args.file:
+ task_str = read_task_from_file(args.file)
+ elif args.task:
+ task_str = args.task
+ elif not sys.stdin.isatty():
+ task_str = read_input(cli_multiline_input)
+
+ return task_str
diff --git a/openhands/core/utils/json.py b/openhands/io/json.py
similarity index 100%
rename from openhands/core/utils/json.py
rename to openhands/io/json.py
diff --git a/openhands/llm/llm.py b/openhands/llm/llm.py
index a9071b43bed3..b40f11ca8396 100644
--- a/openhands/llm/llm.py
+++ b/openhands/llm/llm.py
@@ -172,7 +172,7 @@ def __init__(
)
def wrapper(*args, **kwargs):
"""Wrapper for the litellm completion function. Logs the input and output of the completion function."""
- from openhands.core.utils import json
+ from openhands.io import json
messages: list[dict[str, Any]] | dict[str, Any] = []
mock_function_calling = not self.is_function_calling_active()
@@ -369,7 +369,7 @@ def init_model_info(self):
# noinspection PyBroadException
except Exception:
pass
- from openhands.core.utils import json
+ from openhands.io import json
logger.debug(f'Model info: {json.dumps(self.model_info, indent=2)}')
diff --git a/openhands/memory/condenser/condenser.py b/openhands/memory/condenser/condenser.py
index 878c27aec140..411ed39386f6 100644
--- a/openhands/memory/condenser/condenser.py
+++ b/openhands/memory/condenser/condenser.py
@@ -161,6 +161,12 @@ def __init__(self) -> None:
@override
def condensed_history(self, state: State) -> list[Event]:
+ # The history should grow monotonically -- if it doesn't, something has
+ # truncated the history and we need to reset our tracking.
+ if len(state.history) < self._last_history_length:
+ self._condensation = []
+ self._last_history_length = 0
+
new_events = state.history[self._last_history_length :]
with self.metadata_batch(state):
diff --git a/openhands/memory/condenser/impl/llm_summarizing_condenser.py b/openhands/memory/condenser/impl/llm_summarizing_condenser.py
index 276d1c1e8748..54068f04547c 100644
--- a/openhands/memory/condenser/impl/llm_summarizing_condenser.py
+++ b/openhands/memory/condenser/impl/llm_summarizing_condenser.py
@@ -57,22 +57,29 @@ def condense(self, events: list[Event]) -> list[Event]:
# Construct prompt for summarization
prompt = """You are maintaining state history for an LLM-based code agent. Track:
+USER_CONTEXT: (Preserve essential user requirements, problem descriptions, and clarifications in concise form)
+
STATE: {File paths, function signatures, data structures}
TESTS: {Failing cases, error messages, outputs}
CHANGES: {Code edits, variable updates}
DEPS: {Dependencies, imports, external calls}
INTENT: {Why changes were made, acceptance criteria}
-SKIP: {Git clones, build logs}
-SUMMARIZE: {File listings}
-MAX_LENGTH: Keep summaries under 1000 words
+PRIORITIZE:
+1. Capture key user requirements and constraints
+2. Maintain critical problem context
+3. Keep all sections concise
+
+SKIP: {Git clones, build logs, file listings}
Example history format:
+USER_CONTEXT: Fix FITS card float representation - "0.009125" becomes "0.009124999999999999" causing comment truncation. Use Python's str() when possible while maintaining FITS compliance.
+
STATE: mod_float() in card.py updated
TESTS: test_format() passed
CHANGES: str(val) replaces f"{val:.16G}"
DEPS: None modified
-INTENT: Fix float precision overflow"""
+INTENT: Fix precision while maintaining FITS compliance"""
prompt + '\n\n'
diff --git a/openhands/runtime/action_execution_server.py b/openhands/runtime/action_execution_server.py
index d9ee74c4293a..1a2d4f1d4a7b 100644
--- a/openhands/runtime/action_execution_server.py
+++ b/openhands/runtime/action_execution_server.py
@@ -8,7 +8,6 @@
import argparse
import asyncio
import base64
-import io
import mimetypes
import os
import shutil
@@ -21,12 +20,13 @@
from fastapi import Depends, FastAPI, HTTPException, Request, UploadFile
from fastapi.exceptions import RequestValidationError
-from fastapi.responses import JSONResponse, StreamingResponse
+from fastapi.responses import FileResponse, JSONResponse
from fastapi.security import APIKeyHeader
from openhands_aci.editor.editor import OHEditor
from openhands_aci.editor.exceptions import ToolError
from openhands_aci.editor.results import ToolResult
from pydantic import BaseModel
+from starlette.background import BackgroundTask
from starlette.exceptions import HTTPException as StarletteHTTPException
from uvicorn import run
@@ -631,7 +631,7 @@ async def upload_file(
raise HTTPException(status_code=500, detail=str(e))
@app.get('/download_files')
- async def download_file(path: str):
+ def download_file(path: str):
logger.debug('Downloading files')
try:
if not os.path.isabs(path):
@@ -642,7 +642,7 @@ async def download_file(path: str):
if not os.path.exists(path):
raise HTTPException(status_code=404, detail='File not found')
- with tempfile.TemporaryFile() as temp_zip:
+ with tempfile.NamedTemporaryFile(suffix='.zip', delete=False) as temp_zip:
with ZipFile(temp_zip, 'w') as zipf:
for root, _, files in os.walk(path):
for file in files:
@@ -650,15 +650,11 @@ async def download_file(path: str):
zipf.write(
file_path, arcname=os.path.relpath(file_path, path)
)
- temp_zip.seek(0) # Rewind the file to the beginning after writing
- content = temp_zip.read()
- # Good for small to medium-sized files. For very large files, streaming directly from the
- # file chunks may be more memory-efficient.
- zip_stream = io.BytesIO(content)
- return StreamingResponse(
- content=zip_stream,
+ return FileResponse(
+ path=temp_zip.name,
media_type='application/zip',
- headers={'Content-Disposition': f'attachment; filename={path}.zip'},
+ filename=f'{os.path.basename(path)}.zip',
+ background=BackgroundTask(lambda: os.unlink(temp_zip.name)),
)
except Exception as e:
diff --git a/openhands/runtime/base.py b/openhands/runtime/base.py
index 983fc67fa898..8cdd17e18ead 100644
--- a/openhands/runtime/base.py
+++ b/openhands/runtime/base.py
@@ -254,6 +254,9 @@ async def _handle_action(self, event: Action) -> None:
# this might be unnecessary, since source should be set by the event stream when we're here
source = event.source if event.source else EventSource.AGENT
+ if isinstance(observation, NullObservation):
+ # don't add null observations to the event stream
+ return
self.event_stream.add_event(observation, source) # type: ignore[arg-type]
def clone_repo(
diff --git a/openhands/runtime/impl/action_execution/action_execution_client.py b/openhands/runtime/impl/action_execution/action_execution_client.py
index 258dcf3a85f7..683c16578dad 100644
--- a/openhands/runtime/impl/action_execution/action_execution_client.py
+++ b/openhands/runtime/impl/action_execution/action_execution_client.py
@@ -1,4 +1,5 @@
import os
+import shutil
import tempfile
import threading
from abc import abstractmethod
@@ -143,12 +144,10 @@ def copy_from(self, path: str) -> Path:
stream=True,
timeout=30,
) as response:
- with tempfile.NamedTemporaryFile(delete=False) as temp_file:
- total_length = 0
- for chunk in response.iter_content(chunk_size=8192):
- if chunk: # filter out keep-alive new chunks
- total_length += len(chunk)
- temp_file.write(chunk)
+ with tempfile.NamedTemporaryFile(
+ suffix='.zip', delete=False
+ ) as temp_file:
+ shutil.copyfileobj(response.raw, temp_file, length=16 * 1024)
return Path(temp_file.name)
except requests.Timeout:
raise TimeoutError('Copy operation timed out')
diff --git a/openhands/runtime/impl/remote/remote_runtime.py b/openhands/runtime/impl/remote/remote_runtime.py
index 70e4217e4718..7e1256d28303 100644
--- a/openhands/runtime/impl/remote/remote_runtime.py
+++ b/openhands/runtime/impl/remote/remote_runtime.py
@@ -153,6 +153,12 @@ def _check_existing_runtime(self) -> bool:
return False
self.log('debug', f'Error while looking for remote runtime: {e}')
raise
+ except requests.exceptions.JSONDecodeError as e:
+ self.log(
+ 'error',
+ f'Invalid JSON response from runtime API: {e}. URL: {self.config.sandbox.remote_runtime_api_url}/sessions/{self.sid}. Response: {response}',
+ )
+ raise
if status == 'running':
return True
diff --git a/openhands/server/routes/files.py b/openhands/server/routes/files.py
index 1581d3abaddb..eaa805174f9b 100644
--- a/openhands/server/routes/files.py
+++ b/openhands/server/routes/files.py
@@ -3,7 +3,6 @@
from fastapi import (
APIRouter,
- BackgroundTasks,
HTTPException,
Request,
UploadFile,
@@ -12,6 +11,7 @@
from fastapi.responses import FileResponse, JSONResponse
from pathspec import PathSpec
from pathspec.patterns import GitWildMatchPattern
+from starlette.background import BackgroundTask
from openhands.core.exceptions import AgentRuntimeUnavailableError
from openhands.core.logger import openhands_logger as logger
@@ -309,31 +309,25 @@ async def save_file(request: Request):
@app.get('/zip-directory')
-async def zip_current_workspace(
- request: Request, conversation_id: str, background_tasks: BackgroundTasks
-):
+def zip_current_workspace(request: Request, conversation_id: str):
try:
logger.debug('Zipping workspace')
runtime: Runtime = request.state.conversation.runtime
path = runtime.config.workspace_mount_path_in_sandbox
try:
- zip_file = await call_sync_from_async(runtime.copy_from, path)
+ zip_file_path = runtime.copy_from(path)
except AgentRuntimeUnavailableError as e:
logger.error(f'Error zipping workspace: {e}')
return JSONResponse(
status_code=500,
content={'error': f'Error zipping workspace: {e}'},
)
- response = FileResponse(
- path=zip_file,
+ return FileResponse(
+ path=zip_file_path,
filename='workspace.zip',
- media_type='application/x-zip-compressed',
+ media_type='application/zip',
+ background=BackgroundTask(lambda: os.unlink(zip_file_path)),
)
-
- # This will execute after the response is sent (So the file is not deleted before being sent)
- background_tasks.add_task(zip_file.unlink)
-
- return response
except Exception as e:
logger.error(f'Error zipping workspace: {e}')
raise HTTPException(
diff --git a/poetry.lock b/poetry.lock
index 83c962cb1178..1d994791e089 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -920,7 +920,7 @@ version = "3.4.0"
description = "Validate configuration and produce human readable error messages."
optional = false
python-versions = ">=3.8"
-groups = ["main", "dev", "evaluation"]
+groups = ["dev", "evaluation"]
files = [
{file = "cfgv-3.4.0-py2.py3-none-any.whl", hash = "sha256:b7265b1f29fd3316bfcd2b330d63d024f2bfd8bcb8b0272f8e19a504856c48f9"},
{file = "cfgv-3.4.0.tar.gz", hash = "sha256:e52591d4c5f5dead8e0f673fb16db7949d2cfb3f7da4582893288f0ded8fe560"},
@@ -1634,7 +1634,7 @@ version = "0.3.9"
description = "Distribution utilities"
optional = false
python-versions = "*"
-groups = ["main", "dev", "evaluation"]
+groups = ["dev", "evaluation"]
files = [
{file = "distlib-0.3.9-py2.py3-none-any.whl", hash = "sha256:47f8c22fd27c27e25a65601af709b38e4f0a45ea4fc2e710f65755fa8caaaf87"},
{file = "distlib-0.3.9.tar.gz", hash = "sha256:a60f20dea646b8a33f3e7772f74dc0b2d0772d2837ee1342a00645c81edf9403"},
@@ -3199,7 +3199,7 @@ version = "2.6.7"
description = "File identification library for Python"
optional = false
python-versions = ">=3.9"
-groups = ["main", "dev", "evaluation"]
+groups = ["dev", "evaluation"]
files = [
{file = "identify-2.6.7-py2.py3-none-any.whl", hash = "sha256:155931cb617a401807b09ecec6635d6c692d180090a1cedca8ef7d58ba5b6aa0"},
{file = "identify-2.6.7.tar.gz", hash = "sha256:3fa266b42eba321ee0b2bb0936a6a6b9e36a1351cbb69055b3082f4193035684"},
@@ -3303,7 +3303,7 @@ version = "2.0.0"
description = "brain-dead simple config-ini parsing"
optional = false
python-versions = ">=3.7"
-groups = ["main", "evaluation", "test"]
+groups = ["evaluation", "test"]
files = [
{file = "iniconfig-2.0.0-py3-none-any.whl", hash = "sha256:b6a85871a79d2e3b22d2d1b94ac2824226a63c6b741c88f7ae975f18b6778374"},
{file = "iniconfig-2.0.0.tar.gz", hash = "sha256:2d91e135bf72d31a410b17c16da610a82cb55f6b0477d1a902134b24a455b8b3"},
@@ -5503,7 +5503,7 @@ version = "1.9.1"
description = "Node.js virtual environment builder"
optional = false
python-versions = "!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*,!=3.5.*,!=3.6.*,>=2.7"
-groups = ["main", "dev", "evaluation"]
+groups = ["dev", "evaluation"]
files = [
{file = "nodeenv-1.9.1-py2.py3-none-any.whl", hash = "sha256:ba11c9782d29c27c70ffbdda2d7415098754709be8a7056d79a737cd901155c9"},
{file = "nodeenv-1.9.1.tar.gz", hash = "sha256:6ec12890a2dab7946721edbfbcd91f3319c6ccc9aec47be7c7e6b7011ee6645f"},
@@ -5895,16 +5895,18 @@ realtime = ["websockets (>=13,<15)"]
[[package]]
name = "openhands-aci"
-version = "0.2.4"
+version = "0.2.5"
description = "An Agent-Computer Interface (ACI) designed for software development agents OpenHands."
optional = false
-python-versions = "^3.12"
+python-versions = "<4.0,>=3.12"
groups = ["main"]
-files = []
-develop = false
+files = [
+ {file = "openhands_aci-0.2.5-py3-none-any.whl", hash = "sha256:775a3ea9eacf090ff6fa6819dcc449a359a770f2d25232890441a799b0bd3c2e"},
+ {file = "openhands_aci-0.2.5.tar.gz", hash = "sha256:cfa51834771fb7f35cc754f04ee3b6d8d985df79a6fa4bdd0f57a8a20e9f0883"},
+]
[package.dependencies]
-binaryornot = "^0.4.4"
+binaryornot = ">=0.4.4,<0.5.0"
flake8 = "*"
gitpython = "*"
grep-ast = "0.3.3"
@@ -5912,21 +5914,13 @@ litellm = "*"
networkx = "*"
numpy = "*"
pandas = "*"
-pre-commit = "^4.1.0"
-pytest = "^8.3.4"
scipy = "*"
-tree-sitter = "^0.24.0"
-tree-sitter-javascript = "^0.23.1"
-tree-sitter-python = "^0.23.6"
-tree-sitter-ruby = "^0.23.1"
-tree-sitter-typescript = "^0.23.2"
-whatthepatch = "^1.0.6"
-
-[package.source]
-type = "git"
-url = "https://github.com/All-Hands-AI/openhands-aci.git"
-reference = "fix-memory-issue"
-resolved_reference = "d906bdd60b397fd8c30033a59d8f47f343d6ede4"
+tree-sitter = ">=0.24.0,<0.25.0"
+tree-sitter-javascript = ">=0.23.1,<0.24.0"
+tree-sitter-python = ">=0.23.6,<0.24.0"
+tree-sitter-ruby = ">=0.23.1,<0.24.0"
+tree-sitter-typescript = ">=0.23.2,<0.24.0"
+whatthepatch = ">=1.0.6,<2.0.0"
[[package]]
name = "opentelemetry-api"
@@ -6484,7 +6478,7 @@ version = "1.5.0"
description = "plugin and hook calling mechanisms for python"
optional = false
python-versions = ">=3.8"
-groups = ["main", "evaluation", "test"]
+groups = ["evaluation", "test"]
files = [
{file = "pluggy-1.5.0-py3-none-any.whl", hash = "sha256:44e1ad92c8ca002de6377e165f3e0f1be63266ab4d554740532335b9d75ea669"},
{file = "pluggy-1.5.0.tar.gz", hash = "sha256:2cffa88e94fdc978c4c574f15f9e59b7f4201d439195c3715ca9e2486f1d0cf1"},
@@ -6545,7 +6539,7 @@ version = "4.1.0"
description = "A framework for managing and maintaining multi-language pre-commit hooks."
optional = false
python-versions = ">=3.9"
-groups = ["main", "dev", "evaluation"]
+groups = ["dev", "evaluation"]
files = [
{file = "pre_commit-4.1.0-py2.py3-none-any.whl", hash = "sha256:d29e7cb346295bcc1cc75fc3e92e343495e3ea0196c9ec6ba53f49f10ab6ae7b"},
{file = "pre_commit-4.1.0.tar.gz", hash = "sha256:ae3f018575a588e30dfddfab9a05448bfbd6b73d78709617b5a2b853549716d4"},
@@ -7357,7 +7351,7 @@ version = "8.3.4"
description = "pytest: simple powerful testing with Python"
optional = false
python-versions = ">=3.8"
-groups = ["main", "evaluation", "test"]
+groups = ["evaluation", "test"]
files = [
{file = "pytest-8.3.4-py3-none-any.whl", hash = "sha256:50e16d954148559c9a74109af1eaf0c945ba2d8f30f0a3d3335edde19788b6f6"},
{file = "pytest-8.3.4.tar.gz", hash = "sha256:965370d062bce11e73868e0335abac31b4d3de0e82f4007408d242b4f8610761"},
@@ -10016,7 +10010,7 @@ version = "20.29.2"
description = "Virtual Python Environment builder"
optional = false
python-versions = ">=3.8"
-groups = ["main", "dev", "evaluation"]
+groups = ["dev", "evaluation"]
files = [
{file = "virtualenv-20.29.2-py3-none-any.whl", hash = "sha256:febddfc3d1ea571bdb1dc0f98d7b45d24def7428214d4fb73cc486c9568cce6a"},
{file = "virtualenv-20.29.2.tar.gz", hash = "sha256:fdaabebf6d03b5ba83ae0a02cfe96f48a716f4fae556461d180825866f75b728"},
@@ -10795,4 +10789,4 @@ testing = ["coverage[toml]", "zope.event", "zope.testing"]
[metadata]
lock-version = "2.1"
python-versions = "^3.12"
-content-hash = "395c20a1f1bda924c1177369ce9c1ae27d12966da64b9fa60d91ca7895995c17"
+content-hash = "583a46735c1704428110581400333ce35cd7f6a3f22e5831beb7315ebeeb377a"
diff --git a/pyproject.toml b/pyproject.toml
index e1ba08237e5f..b11d2e8991b8 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
[tool.poetry]
name = "openhands-ai"
-version = "0.24.0"
+version = "0.25.0"
description = "OpenHands: Code Less, Make More"
authors = ["OpenHands"]
license = "MIT"
@@ -67,7 +67,7 @@ runloop-api-client = "0.23.0"
libtmux = ">=0.37,<0.40"
pygithub = "^2.5.0"
joblib = "*"
-openhands-aci = "^0.2.4"
+openhands-aci = "^0.2.5"
python-socketio = "^5.11.4"
redis = "^5.2.0"
sse-starlette = "^2.1.3"
@@ -108,7 +108,6 @@ reportlab = "*"
[tool.coverage.run]
concurrency = ["gevent"]
-
[tool.poetry.group.runtime.dependencies]
jupyterlab = "*"
notebook = "*"
@@ -137,7 +136,6 @@ ignore = ["D1"]
[tool.ruff.lint.pydocstyle]
convention = "google"
-
[tool.poetry.group.evaluation.dependencies]
streamlit = "*"
whatthepatch = "*"
diff --git a/tests/unit/test_cli.py b/tests/unit/test_cli.py
index 520d85d2aa7d..3931f2fdd713 100644
--- a/tests/unit/test_cli.py
+++ b/tests/unit/test_cli.py
@@ -1,7 +1,7 @@
from unittest.mock import patch
-from openhands.core.cli import read_input
from openhands.core.config import AppConfig
+from openhands.io import read_input
def test_single_line_input():
@@ -10,7 +10,7 @@ def test_single_line_input():
config.cli_multiline_input = False
with patch('builtins.input', return_value='hello world'):
- result = read_input(config)
+ result = read_input(config.cli_multiline_input)
assert result == 'hello world'
@@ -23,5 +23,5 @@ def test_multiline_input():
mock_inputs = ['line 1', 'line 2', 'line 3', '/exit']
with patch('builtins.input', side_effect=mock_inputs):
- result = read_input(config)
+ result = read_input(config.cli_multiline_input)
assert result == 'line 1\nline 2\nline 3'
diff --git a/tests/unit/test_condenser.py b/tests/unit/test_condenser.py
index e8c5af60afbb..fd1e922a103a 100644
--- a/tests/unit/test_condenser.py
+++ b/tests/unit/test_condenser.py
@@ -19,6 +19,7 @@
from openhands.events.observation.observation import Observation
from openhands.llm import LLM
from openhands.memory.condenser import Condenser
+from openhands.memory.condenser.condenser import RollingCondenser
from openhands.memory.condenser.impl import (
AmortizedForgettingCondenser,
ImportantEventSelection,
@@ -452,6 +453,49 @@ def test_llm_attention_condenser_invalid_config():
pytest.raises(ValueError, LLMAttentionCondenser.from_config, config)
+def test_rolling_condenser_handles_truncation(mock_state: State):
+ """Test that RollingCondenser correctly handles history truncation."""
+
+ class TestRollingCondenser(RollingCondenser):
+ """Test implementation of RollingCondenser that just returns all events."""
+
+ def condense(self, events: list[Event]) -> list[Event]:
+ return events
+
+ condenser = TestRollingCondenser()
+
+ # Initial history with 3 events
+ events = [
+ create_test_event('Event 1', id=1),
+ create_test_event('Event 2', id=2),
+ create_test_event('Event 3', id=3),
+ ]
+ mock_state.history = events
+
+ # First condensation - should return all events
+ results = condenser.condensed_history(mock_state)
+ assert len(results) == 3
+ assert [e._id for e in results] == [1, 2, 3]
+
+ # Simulate truncation - history is now shorter, and the condensation should
+ # just include the truncated history
+ mock_state.history = mock_state.history[-1:]
+
+ results = condenser.condensed_history(mock_state)
+ assert len(results) == 1
+ assert results[0]._id == 3
+
+ # Adding more events and condensing should "rebase" us from the truncated history
+ mock_state.history += [
+ create_test_event('Event 4', id=4),
+ create_test_event('Event 5', id=5),
+ ]
+
+ results = condenser.condensed_history(mock_state)
+ assert len(results) == 3
+ assert [e._id for e in results] == [3, 4, 5]
+
+
def test_llm_attention_condenser_keeps_first_events(mock_llm, mock_state):
"""Test that the LLMAttentionCondenser keeps the right number of initial events when forgetting."""
max_size = 4
diff --git a/tests/unit/test_json.py b/tests/unit/test_json.py
index 883efdfe4cfb..85ab265a536d 100644
--- a/tests/unit/test_json.py
+++ b/tests/unit/test_json.py
@@ -1,7 +1,7 @@
from datetime import datetime
-from openhands.core.utils import json
from openhands.events.action import MessageAction
+from openhands.io import json
def test_event_serialization_deserialization():
diff --git a/tests/unit/test_json_encoder.py b/tests/unit/test_json_encoder.py
index daa2708a6256..10058c8c2ba3 100644
--- a/tests/unit/test_json_encoder.py
+++ b/tests/unit/test_json_encoder.py
@@ -3,7 +3,7 @@
import psutil
-from openhands.core.utils.json import dumps
+from openhands.io.json import dumps
def get_memory_usage():
diff --git a/tests/unit/test_response_parsing.py b/tests/unit/test_response_parsing.py
index fd588d4c6edf..dc51dee3abe4 100644
--- a/tests/unit/test_response_parsing.py
+++ b/tests/unit/test_response_parsing.py
@@ -2,11 +2,11 @@
from openhands.agenthub.micro.agent import parse_response as parse_response_micro
from openhands.core.exceptions import LLMResponseError
-from openhands.core.utils.json import loads as custom_loads
from openhands.events.action import (
FileWriteAction,
MessageAction,
)
+from openhands.io import loads as custom_loads
@pytest.mark.parametrize(
+