-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None
link title assert hit
#326
Comments
Thanks for pointing these out. Would like to know what @jdufresne thinks on this as well. @equaeghe A pull request that fixes these is welcome. |
OK, see #327. It seems there were some problems detected by the CI, but it wasn't really clear to me what the issue was. I fixed some style issues that were found, getting one extra test to be successful. But for the others, I'll need guidance. (Are they even all due to my changes?) |
Did you have time to look at my pull request. I again hit an issue fixed by it. Namely, someone managed to put a naked |
The general idea makes sense to me once the CI issues are hammered out. |
I'll have a look at them again. I think I now understand better how the CI works and where to find the errors. |
I managed to eliminate all but one of the issues: https://travis-ci.org/github/Alir3z4/html2text/jobs/726262620 I need assistance with this one @Alir3z4 @jdufresne . |
I tried again, but am still hitting an issue I can't seem to solve: https://travis-ci.org/github/Alir3z4/html2text/jobs/737085613 I really need assistance with this one @Alir3z4 @jdufresne . |
Sorry, I missed this The error is coming from mypy
Seems to be type issues on
|
Ah, now I get it! Mypy does not infer that Can you check if you can merge the pull request? |
@jdufresne , @Alir3z4: Bump. |
There is the following in the code:
html2text/html2text/__init__.py
Line 781 in 24aac86
Of course someone managed to produce html with links of the form
<a title href="example.org">…</a>
that trigger this assert. I think better than having the assert would be to replacehtml2text/html2text/__init__.py
Line 780 in 24aac86
with
N.B.: The same type of pattern fixable in the way can be found on three other occasions:
html2text/html2text/__init__.py
Line 502 in 24aac86
html2text/html2text/__init__.py
Line 514 in 24aac86
html2text/html2text/__init__.py
Line 517 in 24aac86
The text was updated successfully, but these errors were encountered: