Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cell type labels are retained when merging SCEs #258

Closed
sjspielman opened this issue Jan 17, 2024 · 3 comments
Closed

Ensure cell type labels are retained when merging SCEs #258

sjspielman opened this issue Jan 17, 2024 · 3 comments
Assignees

Comments

@sjspielman
Copy link
Member

When merging SCEs in scpcaTools::merge_sce_list(), we use a vector of colData columns to retain. Missing from this list are cell type annotation columns, but we would definitely like to retain them. We'll need to update the function, and its docs, accordingly.

@sjspielman sjspielman self-assigned this Jan 17, 2024
@allyhawkins
Copy link
Member

My understanding from DSTM was that we don't want to actually change the function, we just want to change the vector of column names that we provide when calling the function in scpca-nf. We will need to add the retain_coldata_cols argument here:
https://github.com/AlexsLemonade/scpca-nf/blob/f08ce452f95f88e169217c114aef1c1321a3688c/bin/merge_sces.R#L132

@sjspielman
Copy link
Member Author

We will need to add the retain_coldata_cols argument here:

This won't work with our current implementation - I'm filing a PR for this fix now, eta 1 minute.

@sjspielman
Copy link
Member Author

Indeed, this will happen in scpca-nf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants