Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tidy patches into plugins #6

Open
elieux opened this issue Feb 3, 2015 · 5 comments
Open

Refactor tidy patches into plugins #6

elieux opened this issue Feb 3, 2015 · 5 comments

Comments

@elieux
Copy link
Contributor

elieux commented Feb 3, 2015

I see there are some big patches for the tidying phase of makepkg. Now that the phase is extendable, maybe some of the MSYS2-specific code should be put into separate files for better maintainability?

@Alexpux
Copy link
Owner

Alexpux commented Feb 3, 2015

it already put. See develop branch. I'm build pacman with this changes when I test it.

@elieux
Copy link
Contributor Author

elieux commented Feb 3, 2015

Yeah, I know that you already merged the change into msys2-pacman. I meant that the strip plugin is now very big and does various stuff not related to stripping, for example handling executable files without .exe extension (https://github.com/Alexpux/MSYS2-pacman/blob/develop/scripts/libmakepkg/tidy/strip.sh.in#L86-101). Maybe this part of the strip plugin could now be a separate plugin.

@Alexpux
Copy link
Owner

Alexpux commented Feb 3, 2015

i don't want to split this code because it hard to maintain it. this procedures a get from cygwin build system.

@elieux
Copy link
Contributor Author

elieux commented Feb 3, 2015

this procedures a get from cygwin build system

Could you point me to where you got these procedures? I found only cygbuild, but their code is very different to the one in MSYS2 makepkg.

@Alexpux
Copy link
Owner

Alexpux commented Feb 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants