fix(frontend): Prevent from send a SET API key (All-Hands-AI#6235)

AlexCuadron · Jan 13, 2025 · 80dfa1f · 80dfa1f
1 parent 2fc5a9c
commit 80dfa1f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/frontend/__tests__/components/features/sidebar/sidebar.test.tsx b/frontend/__tests__/components/features/sidebar/sidebar.test.tsx
@@ -141,5 +141,30 @@ describe("Sidebar", () => {
         llm_api_key: undefined, // null or undefined
       });
     });
+
+    it("should not send the api key if its SET", async () => {
+      const user = userEvent.setup();
+      renderSidebar();
+
+      const settingsButton = screen.getByTestId("settings-button");
+      await user.click(settingsButton);
+
+      const settingsModal = screen.getByTestId("ai-config-modal");
+
+      const apiKeyInput = within(settingsModal).getByLabelText(/api key/i);
+      await user.type(apiKeyInput, "SET");
+
+      const saveButton = within(settingsModal).getByTestId(
+        "save-settings-button",
+      );
+      await user.click(saveButton);
+
+      expect(saveSettingsSpy).toHaveBeenCalledWith({
+        ...MOCK_USER_PREFERENCES.settings,
+        llm_api_key: undefined,
+        llm_base_url: undefined,
+        security_analyzer: undefined,
+      });
+    });
   });
 });
diff --git a/frontend/src/context/settings-context.tsx b/frontend/src/context/settings-context.tsx
@@ -33,6 +33,11 @@ export function SettingsProvider({ children }: SettingsProviderProps) {
       ...userSettings,
       ...newSettings,
     };
+
+    if (updatedSettings.LLM_API_KEY === "SET") {
+      delete updatedSettings.LLM_API_KEY;
+    }
+
     await saveSettings(updatedSettings, {
       onSuccess: () => {
         if (!isUpToDate) {