Skip to content

Commit 882b61a

Browse files
committed
doc: fix more links
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: nodejs#32586 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 77f9e0c commit 882b61a

File tree

6 files changed

+11
-9
lines changed

6 files changed

+11
-9
lines changed

GOVERNANCE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* [Technical Steering Committee](#technical-steering-committee)
88
* [TSC Meetings](#tsc-meetings)
99
* [Collaborator Nominations](#collaborator-nominations)
10-
* [Onboarding](#./onboarding)
10+
* [Onboarding](#onboarding)
1111
* [Consensus Seeking Process](#consensus-seeking-process)
1212

1313
<!-- /TOC -->

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ For information about the governance of the Node.js project, see
349349
**Matteo Collina** &lt;[email protected]&gt; (he/him)
350350
* [mhdawson](https://github.com/mhdawson) -
351351
**Michael Dawson** &lt;[email protected]&gt; (he/him)
352-
* [mildsunrise](https://github.com/mildsunrise)
352+
* [mildsunrise](https://github.com/mildsunrise) -
353353
**Alba Mendez** &lt;[email protected]&gt; (she/her)
354354
* [misterdjules](https://github.com/misterdjules) -
355355
**Julien Gilli** &lt;[email protected]&gt;

doc/guides/collaborator-guide.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -752,13 +752,13 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
752752

753753
["Merge Pull Request"]: https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github
754754
[Deprecation]: https://en.wikipedia.org/wiki/Deprecation
755-
[Stability Index]: doc/api/documentation.md#stability-index
755+
[Stability Index]: ../api/documentation.md#stability-index
756756
[TSC]: https://github.com/nodejs/TSC
757-
[`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation
758-
[`--throw-deprecation`]: doc/api/cli.md#--throw-deprecation
757+
[`--pending-deprecation`]: ../api/cli.md#--pending-deprecation
758+
[`--throw-deprecation`]: ../api/cli.md#--throw-deprecation
759759
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
760-
[backporting guide]: doc/guides/backporting-to-release-lines.md
761-
[commit message guidelines]: ./doc/guides/contributing/pull-requests.md#commit-message-guidelines
760+
[backporting guide]: backporting-to-release-lines.md
761+
[commit message guidelines]: contributing/pull-requests.md#commit-message-guidelines
762762
[commit-example]: https://github.com/nodejs/node/commit/b636ba8186
763763
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
764764
[git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata

doc/guides/doc-style-guide.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,4 @@ See also API documentation structure overview in [doctools README][].
6868
[Javascript type]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Grammar_and_types#Data_structures_and_types
6969
[serial commas]: https://en.wikipedia.org/wiki/Serial_comma
7070
[plugin]: https://editorconfig.org/#download
71-
[doctools README]: ../tools/doc/README.md
71+
[doctools README]: ../../tools/doc/README.md

onboarding.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ onboarding session.
110110
organization (not just Collaborators on Node.js core) have access. Its
111111
contents should not be shared externally.
112112
* You can find the full moderation policy
113-
[here](https://github.com/nodejs/TSC/blob/master/Moderation-Policy.md).
113+
[here](https://github.com/nodejs/admin/blob/master/Moderation-Policy.md).
114114

115115
## Reviewing PRs
116116

tools/doc/checkLinks.js

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ function findMarkdownFilesRecursively(dirPath) {
2727
if (
2828
entry.isDirectory() &&
2929
entry.name !== 'api' &&
30+
entry.name !== 'fixtures' &&
31+
entry.name !== 'changelogs' &&
3032
entry.name !== 'deps' &&
3133
entry.name !== 'node_modules'
3234
) {

0 commit comments

Comments
 (0)