Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra line breaks in app description on F-Droid #72

Open
Korb opened this issue Jan 28, 2025 · 10 comments
Open

Remove extra line breaks in app description on F-Droid #72

Korb opened this issue Jan 28, 2025 · 10 comments

Comments

@Korb
Copy link

Korb commented Jan 28, 2025

Please remove unnecessary line breaks:

Image

@farfromrefug
Copy link
Collaborator

farfromrefug commented Jan 28, 2025

@Korb good catch!

@IzzySoft just realized the description on IoD is not in sync with the fastlane metadata. What can i do to fix it?

@IzzySoft
Copy link

just realized the description on IoD is not in sync with the fastlane metadata. What can i do to fix it?

Let me see:

  Fastlane: https://github.com/Akylas/alpimaps/tree/master/fastlane/metadata/android/en-US
  FastlaneFeatures: title,shortdesc,icon,featureGraphic,screenshotsJPG
  FastlaneIgnore: video,fulldesc
  Note: video.txt empty, fulldesc needs reformatting (linebreaks, lists)

Hm…

Map features:
• enjoy more that 50 different map styles
• enjoy more that 20 different map overlay styles like ski trails

That might work with PlayStore. And if you want us to switch to "display-as-is" instead of "format-it-properly", that can be done, too. But if you want the formatting done nicely (as it's currently at IoD thanks to "manual adjustment"), it would mean something like this:

<b>Map features:</b>

- enjoy more that 50 different map styles
- enjoy more that 20 different map overlay styles like ski trails
  • the HTML (here: <b>) is totally optional, but supported by Play, F-Droid and IoD.
  • the empty line is needed to separate the "paragraph" from the "bullet point list"
  • "graphical" bullet-points (as you currently use them) won't work as they cannot be recognized properly (they are multi-byte characters instead of the plain-ASCII-7bit ones needed; working characters are * - +

For additional hints, please take a look at the IzzyOnDroid Fastlane Documentation. Let me know when you're ready, so I can take another look and hopefully pull in your updates 😉 Thanks!

@farfromrefug
Copy link
Collaborator

farfromrefug commented Jan 28, 2025

@IzzySoft you mean my description was not updated from.my current file because the format is not correct? No problem changing it. Just want to understand
BTW fdroid just asked me to switch my descriptions to HTML. Would that be good for you ?

@IzzySoft
Copy link

you mean my description was not updated from.my current file because the format is not correct?

In a way, yes. At one point I pulled the description (either from your Fastlane, or from what PlayStore had) and formatted it properly. For the best "first impression" so to say 😉

BTW fdroid just asked me to switch my descriptions to HTML. Would that be good for you ?

Read the link to the IzzyOnDroid Fastlane Documentation I've sent you 🤪 Yes, perfectly fine. Hint (in case you again forget to check the link): If you format it entirely in HTML (i.e. including <p> and all), "condensing" it to a single line helps keeping F-Droid from inserting <br>s at each line break (as then there are no more line breaks). Works fine for F-Droid.org and IzzyOnDroid as well – though I cannot tell what PlayStore might do with that (with "full HTML" I mean).

Just let me know when it's up. I'd then cross-check, give you some feedback, and maybe even directly trigger a "pull" (if all's fine that is). Thanks!

@farfromrefug
Copy link
Collaborator

@IzzySoft sorry it is not that i forgot to read your link. It is that i remember that quite a long time ago i switched to markdown from html upon your advice. Which is why i want to make sure it is ok with you.
It remains the issue of playstore with html description though :s will have to check.
Thanks

@IzzySoft
Copy link

No prob. Check with the linked documentation for "Markdown Lite", that's something in the middle (using some HTML tags while not being full HTML; that's what works best with all 3 places).

@farfromrefug
Copy link
Collaborator

@IzzySoft i updated the full_description and checked its rendering on the playstore.
Will modify all my apps to use markdown lite

@IzzySoft
Copy link

IzzySoft commented Jan 29, 2025

<p><i>Alpi Maps</i> is an outdoor companion app</p>
<b>Map features:</b>
- enjoy more that 50 different map styles
- enjoy more that 20 different map overlay styles like ski trails
- enable / disable HD map for each style
- combine map styles with opacity to create your own map
- enjoy Google Maps style, traffic layers and buildings
- enjoy rotating and tilting map
- use the Google Maps gestures you love so much like the double tap and drag to zoom!
- see slopes percentages (based on hill-shading data source offline/online)

That will render as 2 paragraphs: first paragraph will be the first line (as wrapped inside <p></p>), second paragraph the rest (not wrapped inside "block-level" markers, and line-break missing before the bullet-point list). "Markdown Lite" would look like this:

<i>Alpi Maps</i> is an outdoor companion app

<b>Map features:</b>

- enjoy more that 50 different map styles
- enjoy more that 20 different map overlay styles like ski trails
- enable / disable HD map for each style
- combine map styles with opacity to create your own map
- enjoy Google Maps style, traffic layers and buildings
- enjoy rotating and tilting map
- use the Google Maps gestures you love so much like the double tap and drag to zoom!
- see slopes percentages (based on hill-shading data source offline/online)

@farfromrefug
Copy link
Collaborator

@IzzySoft thanks for explaining ! Just updated to markdown lite (this time)

@IzzySoft
Copy link

FastlaneFeatures: title,shortdesc,fulldescMD,icon,featureGraphic,screenshotsJPG

and pulled the trigger… err, triggered the pull. New description in place for the next index generation and sync. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants