You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When get_service is called, it is possible that the service responds with something other than success. At the moment this causes an exception - it would be better to output a message and return an "empty" result.
The text was updated successfully, but these errors were encountered:
@TibsAtWork
I created a new class to implement this, and added some tests.
The code seems fairly readable to me, but I am not entirely sure how well I followed best practices, feel free to be harsh on feedback :).
There may be some conflicts with #58 and #59. I minimized/avoided some changes in these PRs to avoid conflicts as much as possible(e.g.: CI, git hooks). I'll do the changes at a later date.
When
get_service
is called, it is possible that the service responds with something other than success. At the moment this causes an exception - it would be better to output a message and return an "empty" result.The text was updated successfully, but these errors were encountered: