Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cope when a service has "gone away" #28

Open
TibsAtWork opened this issue Jul 18, 2022 · 2 comments · May be fixed by #60
Open

Cope when a service has "gone away" #28

TibsAtWork opened this issue Jul 18, 2022 · 2 comments · May be fixed by #60
Assignees
Labels
bug Something isn't working

Comments

@TibsAtWork
Copy link
Contributor

When get_service is called, it is possible that the service responds with something other than success. At the moment this causes an exception - it would be better to output a message and return an "empty" result.

@TibsAtWork TibsAtWork self-assigned this Jul 18, 2022
@TibsAtWork TibsAtWork added the bug Something isn't working label Jul 18, 2022
@inifares23lab
Copy link
Contributor

Hi
Can I tackle this?
how can I reproduce the described behaviour?

would you like something like this:
except Exception as e: print(f"Error getting service: {service_name} in project: {project}\nException: {e}")

@inifares23lab inifares23lab mentioned this issue Oct 8, 2023
1 task
@inifares23lab inifares23lab linked a pull request Dec 10, 2023 that will close this issue
@inifares23lab
Copy link
Contributor

@TibsAtWork
I created a new class to implement this, and added some tests.

The code seems fairly readable to me, but I am not entirely sure how well I followed best practices, feel free to be harsh on feedback :).

There may be some conflicts with #58 and #59. I minimized/avoided some changes in these PRs to avoid conflicts as much as possible(e.g.: CI, git hooks). I'll do the changes at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants