Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UncorEncounterModel/sample sets altitude limits to empty if model does not have an altitude layer variable #31

Closed
aweinert-MIT opened this issue Jan 28, 2022 · 0 comments · Fixed by #33
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aweinert-MIT
Copy link
Member

Description

UncorEncounterModel.sample will set altitude minimum (min_alt_ft) and maximum (max_alt_ft) thresholds as empty if idx_L is empty. This happens when the model parameters file does not specify boundaries for the altitude layer variable

Reproducibility

Change RUN_uncor to use an unconventional model parameter file that doesn't have an altitude layer variable, such as

parameters_filename = [getenv('AEM_DIR_BAYES') filesep 'model' filesep 'blimp_v1.txt'];
% parameters_filename = [getenv('AEM_DIR_BAYES') filesep 'model' filesep 'uncor_1200exclude_rotorcraft_v1p2.txt'];

Expectation

Identify if idx_L is empty and set default values for min_alt_ft and max_alt_ft instead of setting values based on the model

@aweinert-MIT aweinert-MIT added the bug Something isn't working label Jan 28, 2022
@aweinert-MIT aweinert-MIT self-assigned this Jan 28, 2022
@aweinert-MIT aweinert-MIT added the good first issue Good for newcomers label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant