Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling options validation for production use. #81

Open
GuillaumeRochat opened this issue Jul 22, 2020 · 2 comments
Open

Allow disabling options validation for production use. #81

GuillaumeRochat opened this issue Jul 22, 2020 · 2 comments
Assignees
@Airfooox

Comments

@GuillaumeRochat
Copy link
Contributor

While running the test repeatedly, I noticed that the time it takes to do a validation is quite high, around 2-5ms per check. With some debugging, I noticed that most of that time is from the runtime checks on the options and presets by yup.

Considering that the options and preset will be hardcoded, yup could be disabled in the production build to significantly cut on runtime. For example, the tests for the blank symbol ? take between 100ms and 200ms with yup enabled, but around 2ms with up disabled.
@Airfooox Airfooox self-assigned this Jul 22, 2020
@albertodiazdorado albertodiazdorado mentioned this issue Dec 10, 2024
Closed
@albertodiazdorado
Copy link

Addressed in #299

@albertodiazdorado albertodiazdorado mentioned this issue Dec 20, 2024
Open
@albertodiazdorado
Copy link

New PR addressing the topic: #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Airfooox Airfooox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GuillaumeRochat @albertodiazdorado @Airfooox