From cfe4e557c7dc29a2cb560b6dddbaf6dfef34adf0 Mon Sep 17 00:00:00 2001 From: Muhammad Ahsan Ayaz Date: Wed, 26 May 2021 11:56:14 +0200 Subject: [PATCH] fix(jest): fix jest env issues for running testS --- package.json | 3 +++ projects/demo/tsconfig.app.json | 9 ++------- .../src/lib/device-detector.service.spec.ts | 19 +++++++++---------- 3 files changed, 14 insertions(+), 17 deletions(-) diff --git a/package.json b/package.json index e98655b..62cacd5 100644 --- a/package.json +++ b/package.json @@ -50,6 +50,9 @@ "/node_modules/", "/dist/" ], + "modulePathIgnorePatterns": [ + "/dist/" + ], "globals": { "ts-jest": { "tsconfig": "/tsconfig.spec.json", diff --git a/projects/demo/tsconfig.app.json b/projects/demo/tsconfig.app.json index fd37f74..c3c4837 100644 --- a/projects/demo/tsconfig.app.json +++ b/projects/demo/tsconfig.app.json @@ -5,11 +5,6 @@ "outDir": "../../out-tsc/app", "types": [] }, - "files": [ - "src/main.ts", - "src/polyfills.ts" - ], - "include": [ - "src/**/*.d.ts" - ] + "files": ["src/main.ts", "src/polyfills.ts"], + "include": ["src/**/*.d.ts"] } diff --git a/projects/ngx-device-detector/src/lib/device-detector.service.spec.ts b/projects/ngx-device-detector/src/lib/device-detector.service.spec.ts index d854144..7514eee 100644 --- a/projects/ngx-device-detector/src/lib/device-detector.service.spec.ts +++ b/projects/ngx-device-detector/src/lib/device-detector.service.spec.ts @@ -18,7 +18,7 @@ describe('DeviceDetectorService', () => { expect(service).toBeTruthy(); })); - it('should return device info object when getDeviceInfo is called', inject( + it('should return device info object for iPhone when getDeviceInfo is called', inject( [DeviceDetectorService], (service: DeviceDetectorService) => { const userAgent = @@ -38,7 +38,7 @@ describe('DeviceDetectorService', () => { } )); - it('should return device details when system is desktop', inject( + it('should return device details when system is desktop and using Linux & Chrome', inject( [DeviceDetectorService], (service: DeviceDetectorService) => { const userAgent = @@ -52,14 +52,13 @@ describe('DeviceDetectorService', () => { )); // tslint:disable-next-line: max-line-length - it('should return false when isDesktop is called on a non-desktop userAgent', inject( - [DeviceDetectorService], - (service: DeviceDetectorService) => { - // tslint:disable-next-line:max-line-length - const userAgent = `Mozilla/5.0 (iPad; CPU OS 11_0 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) Version/11.0 Mobile/15A5341f Safari/604.1`; - expect(service.isDesktop(userAgent)).toBeFalsy(); - } - )); + it('should detect an iPad correctly', inject([DeviceDetectorService], (service: DeviceDetectorService) => { + // tslint:disable-next-line:max-line-length + const userAgent = `Mozilla/5.0 (iPad; CPU OS 11_0 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) Version/11.0 Mobile/15A5341f Safari/604.1`; + expect(service.isDesktop(userAgent)).toBeFalsy(); + expect(service.isTablet(userAgent)).toBeTruthy(); + expect(service.isMobile(userAgent)).toBeFalsy(); + })); it('should return true, os=`Mac`, browser=`Safari`, device=`iPad` and browser_version=`11.0` when system is iPad tablet', inject( [DeviceDetectorService],