Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Storage #91

Open
1 of 3 tasks
MrF3lix opened this issue Apr 21, 2022 · 2 comments
Open
1 of 3 tasks

Token Storage #91

MrF3lix opened this issue Apr 21, 2022 · 2 comments
Assignees
Labels
api This issue is related to the API editor This issue is related to the editor executor This issue is related to the executor

Comments

@MrF3lix
Copy link
Contributor

MrF3lix commented Apr 21, 2022

As a user I want to be able to save tokens as secrets to access other APIs that require an access token.

Important:

  • Research how to safely store tokens.

Acceptance Criteria

  • The editor should allow to save tokens. Tokens should never be visible to the user.
  • The api should be able to save, update, delete tokens.
  • The executor should be able to replace variables in nodes with tokens.

Related

The following issues have been created as sub-issues:

@MrF3lix MrF3lix added editor This issue is related to the editor api This issue is related to the API executor This issue is related to the executor labels Apr 21, 2022
@MrF3lix
Copy link
Contributor Author

MrF3lix commented Apr 22, 2022

The following issues have been created as sub-issues:

@DuplosFidibuss
Copy link
Contributor

So far, I have figured some possibilities to safely store user secrets in the API as follows:

The solution suggested by partech.nl makes use of IDataProtectionProvider (https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.dataprotection.idataprotectionprovider?view=aspnetcore-6.0) and IDataProtector (https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.dataprotection.idataprotector?view=aspnetcore-6.0) and seems to be a useful approach.
The solutions described on the stackoverflow post include using the Identity Protected attribute, which would lead to extending our current identity implementation to allow for storing user tokens as protected values.

@MrF3lix MrF3lix moved this from Todo to In Progress in Development V1 May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api This issue is related to the API editor This issue is related to the editor executor This issue is related to the executor
Projects
Status: In Progress
Development

No branches or pull requests

3 participants