Improves Apple pay errors #69
Conversation
|
|
Hello @dimitriBouteille, Thank you for your contribution. We will review this PR and merge it afterwards. Best Regards, |
|
Hi @RokPopov & @candemiralp Can you look this MR in order to maybe include it in the next release. Thanks ! |
| agreement_ids: window.checkout.agreementIds | ||
| }; | ||
| } | ||
| postData.paymentMethod = agreementsAssigner(postData.paymentMethod); |
There was a problem hiding this comment.
Hello @dimitriBouteille,
Thank you for your contribution. I see that you've implemented the usage of agreementsAssigner(). However, I couldn't find the relevant import in RequireJS import block.
Is Magento_CheckoutAgreements/js/model/agreements-assigner required to be imported to the class?
Best regards,
Can
There was a problem hiding this comment.
Hi @candemiralp
I think this line can be remove :)
Summary
This MR improves error display with Apple Pay checkout. The user can easily change the error handling thanks to the new functions.
onShippingContactSelect
The
addressUnserviceableerror is displayed by ApplePay if not shipping method.startPlaceOrder
The explicit placeOrder error or
Your payment failed, Please try again lateris displayed in the cart if an error occurs during the placeOrder.Resolve #59