-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StoredPaymentMethodDetails doesn't have support for the "subtype" field used by the native TWINT drop-in #1360
Comments
Hi @elitalon, Thanks for reaching out here, we have a fix on the way! Best, Jilling |
Hi @jillingk. Are there any news on this? I've seen a few releases of the library in the past weeks, but none of them seem to mention this issue. Thanks! |
Hi @elitalon! We've merged the fix from this PR (#1380): src/main/java/com/adyen/model/checkout/TwintDetails.java. Would you be willing to check the fix and confirm that it addresses the issue before we proceed with the release? We appreciate your help! Best regards, |
@DjoykeAbyah Thanks for the heads up 👍🏼 I will give it a try. |
@DjoykeAbyah Speaking of testing, how do you intend us to reach that change without a new version? Specifically, how can we point to the current state of the |
Hey @elitalon thanks for helping out. We are not able to deploy a snapshot yet (we are looking at the options and we hope to do so in the near future) so it is indeed difficult to test. If that's not doable I understand, if you can please check the changes introduced by the PR #1380 and let us know if they look what you'd expect, that would be tremendously helpful. We are planning the new release shortly. |
@gcatanese I'll try building from source. If that doesn't work, then I'll take a look at the pull request. Cheers! |
Hi @gcatanese, I was able to build from source and test the integration agains our backend. I also took a look at #1380. I think we should be good to go, as far as this issue is concerned. It could be that we find something else when trying an end-to-end registration together with the iOS SDK. But in that case we will open a separate issue. Thanks a lot! |
That's great, thank you so much @elitalon for your help. |
Thanks a lot, @DjoykeAbyah! |
Describe the bug
Deserialisation of a
POST /payments
request done against a proxy backend ignores thesubtype
field from thepaymentMethod
object in the JSON body.This results in the drop-in integration of TWINT for iOS using a web-based UI instead of the native one.
How to reproduce
Make a
POST /payments
request with the following JSON body:Expected behavior
The resulting
StoredPaymentMethodDetails
object stores the value of thesubtype
JSON field.Screenshots
Not applicable
Desktop (please complete the following information):
Additional context
This problem was discovered as part of Adyen/adyen-ios#1783.
The text was updated successfully, but these errors were encountered: