From 715703c7a43ccba35bbe149e095710cff3b917a9 Mon Sep 17 00:00:00 2001 From: Caio Faustino Date: Tue, 3 Nov 2020 11:42:13 +0100 Subject: [PATCH] Code checks --- .../main/java/com/adyen/checkout/card/data/CardType.java | 2 +- .../main/java/com/adyen/checkout/card/CardComponent.java | 6 ++++-- .../java/com/adyen/checkout/card/CardConfiguration.java | 5 +++-- card-ui/src/main/java/com/adyen/checkout/card/CardView.java | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/card-base-core/src/main/java/com/adyen/checkout/card/data/CardType.java b/card-base-core/src/main/java/com/adyen/checkout/card/data/CardType.java index eaee4934e8..50994ad2a1 100644 --- a/card-base-core/src/main/java/com/adyen/checkout/card/data/CardType.java +++ b/card-base-core/src/main/java/com/adyen/checkout/card/data/CardType.java @@ -93,7 +93,7 @@ public static List estimate(@NonNull String cardNumber) { /** * Get CardType from the brand name as it appears in the Checkout API. - * @see + * @see */ @Nullable public static CardType getByBrandName(@NonNull String brand) { diff --git a/card-base/src/main/java/com/adyen/checkout/card/CardComponent.java b/card-base/src/main/java/com/adyen/checkout/card/CardComponent.java index de0b6c91bf..1e324f0399 100644 --- a/card-base/src/main/java/com/adyen/checkout/card/CardComponent.java +++ b/card-base/src/main/java/com/adyen/checkout/card/CardComponent.java @@ -51,7 +51,7 @@ public final class CardComponent extends BasePaymentComponent< private static final Set NO_CVC_BRANDS; static { - HashSet brandSet = new HashSet<>(); + final HashSet brandSet = new HashSet<>(); brandSet.add(CardType.BCMC); NO_CVC_BRANDS = Collections.unmodifiableSet(brandSet); } @@ -173,7 +173,9 @@ protected CardComponentState createComponentState() { card.setNumber(outputData.getCardNumberField().getValue()); } - card.setSecurityCode(isCvcHidden() ? null : outputData.getSecurityCodeField().getValue()); + if (!isCvcHidden()) { + card.setSecurityCode(outputData.getSecurityCodeField().getValue()); + } final ExpiryDate expiryDateResult = outputData.getExpiryDateField().getValue(); diff --git a/card-base/src/main/java/com/adyen/checkout/card/CardConfiguration.java b/card-base/src/main/java/com/adyen/checkout/card/CardConfiguration.java index 90827687c1..f3b833aeed 100644 --- a/card-base/src/main/java/com/adyen/checkout/card/CardConfiguration.java +++ b/card-base/src/main/java/com/adyen/checkout/card/CardConfiguration.java @@ -83,7 +83,7 @@ public CardConfiguration[] newArray(int size) { @NonNull List supportCardTypes, boolean hideCvc, boolean hideCvcStoredCard - ) { + ) { super(shopperLocale, environment, clientKey); mPublicKey = publicKey; @@ -319,7 +319,8 @@ public Builder setShowStorePaymentField(boolean showStorePaymentField) { /** * Set the unique reference for the shopper doing this transaction. - * This value will simply be passed back to you in the {@link com.adyen.checkout.base.model.payments.request.PaymentComponentData} for convenience. + * This value will simply be passed back to you in the {@link com.adyen.checkout.base.model.payments.request.PaymentComponentData} + * for convenience. * * @param shopperReference The unique shopper reference * @return {@link CardConfiguration.Builder} diff --git a/card-ui/src/main/java/com/adyen/checkout/card/CardView.java b/card-ui/src/main/java/com/adyen/checkout/card/CardView.java index 6358cd9a42..24a40e1d1d 100644 --- a/card-ui/src/main/java/com/adyen/checkout/card/CardView.java +++ b/card-ui/src/main/java/com/adyen/checkout/card/CardView.java @@ -176,7 +176,7 @@ public void onChanged(@Nullable CardOutputData cardOutputData) { if (cardOutputData != null) { onCardNumberValidated(cardOutputData.getCardNumberField()); onExpiryDateValidated(cardOutputData.getExpiryDateField()); - mSecurityCodeInput.setVisibility( cardOutputData.isCvcHidden() ? GONE : VISIBLE); + mSecurityCodeInput.setVisibility(cardOutputData.isCvcHidden() ? GONE : VISIBLE); } if (getComponent().isStoredPaymentMethod()) {