Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 589, Adding AlmaLinux support - config, scripts, document changes #592

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

srbala
Copy link
Contributor

@srbala srbala commented Jun 29, 2021

This Pull reqeust addes AlmaLinux as one of the suppoted OSs. Resolves #589.

It contains the changes required for config files, shell scripts, test scripts and documentaion.

Docker files change will be added as seperated PR. This way code review will be cleaner.

@karianna karianna added this to the June 2021 milestone Jun 29, 2021
@karianna
Copy link
Member

@gdams - I think I'm OK with landing this here - I know at Adoptium we'll have a reduced set.

@karianna karianna requested a review from gdams June 29, 2021 18:45
@srbala
Copy link
Contributor Author

srbala commented Jun 29, 2021

I know at Adoptium we'll have a reduced set.
@karianna Any discussion on future of this repo in Adoptium PMC, links or more info.

@karianna
Copy link
Member

I know at Adoptium we'll have a reduced set.
@karianna Any discussion on future of this repo in Adoptium PMC, links or more info.

@gdams - I'm guessing the minutes of the various PMC meetings cover this?

@srbala
Copy link
Contributor Author

srbala commented Jun 30, 2021

I have docker file changes ready to go. I can request new PR for docker files when current PR is approved and merged. https://github.com/srbala/openjdk-docker/tree/fix-589-pr2

@sxa
Copy link
Member

sxa commented Jul 5, 2021

@gdams - I'm guessing the minutes of the various PMC meetings cover this?

ping @gdams for confirmation on the above.

I think I'm OK with landing this here - I know at Adoptium we'll have a reduced set.

@karianna I'm personally a little nervous about adding something we potentially won't support going forward (which isn't far away!) :-\

@karianna
Copy link
Member

karianna commented Jul 5, 2021

Yeah, maybe one to ask the PMC (should we support this).

@karianna
Copy link
Member

karianna commented Jul 7, 2021

Holding off for now. See adoptium/containers#1

@karianna karianna marked this pull request as draft July 7, 2021 13:43
@saper
Copy link

saper commented Jul 27, 2021

The question here is rather what will be a replacement of a current CentOS docker image; although CentOS 8 is going to limp towards the end of 2021 with RPM updates, as of 2021-07-21 they haven't published 8.4 update, so users are stuck with unsupported 8.3 image from December 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AlmaLinux as supported OS
4 participants