Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan about i18n? #307

Open
cyberdak opened this issue Jul 8, 2019 · 20 comments
Open

Any plan about i18n? #307

cyberdak opened this issue Jul 8, 2019 · 20 comments

Comments

@cyberdak
Copy link
Contributor

cyberdak commented Jul 8, 2019

Now JITWatch only provide English language.

@chriswhocodes
Copy link
Member

Hi @cyberdak
What language(s) were you thinking about?
There aren't too many Strings in the UI so I guess I could move them to properties files but someone else would have to do the translations into other languages!
Are you volunteering to do the translations?
Cheers,
Chris

@cyberdak
Copy link
Contributor Author

cyberdak commented Jul 9, 2019

I am Chinese , I can do translate when we hava properites files to do this.

@JCWasmx86
Copy link
Contributor

JCWasmx86 commented Jun 11, 2020

I could do the german translation

@grzesuav
Copy link

grzesuav commented Apr 9, 2021

I can do polish :)

@chriswhocodes
Copy link
Member

Hi all,
I have just pushed a commit to start the i18n of JITWatch 4b22da3
If you're happy to help then please send PRs with translations in the properties files :)
I'm happy to take care of the code side, replacing English String literals with calls to the property keys.
Thanks!
Chris

@chriswhocodes
Copy link
Member

For each translation you can add a tooltip if you think it is helpful:

SANDBOX=Sandbox
SANDBOX_tt=Experiment with JIT behaviour

@chriswhocodes
Copy link
Member

The properties files for translations live in ui/src/main/resources/i18n/

@lcaron
Copy link

lcaron commented Apr 16, 2021

I can work on french translation

@chriswhocodes
Copy link
Member

Thank you @lcaron I've created an empty file for French translations: ui/src/main/resources/i18n/lang_fr.properties

I will continue replacing literals with i18n constants in the base properties file.

:)

@ldebello
Copy link
Contributor

I can work on spanish translation

@chriswhocodes
Copy link
Member

Thank you @ldebello I've created an empty file for Spanish translations: ui/src/main/resources/i18n/lang_fr.properties
The language constants to complete can be copied from lang.properties
For each translation there is a tooltip translation named with _tt suffix e.g.

SANDBOX=Sandbox
SANDBOX_tt=Experiment with JIT behaviour

Thanks to all the translators, if you need to ask me about the meaning of a button please feel free :)

chriswhocodes added a commit that referenced this issue Apr 17, 2021
@ldebello
Copy link
Contributor

PR sent for spanish: #344

Proposal [WIP] to add combobox for languages: #345

@chriswhocodes
Copy link
Member

POM file updated with translation contributors :)
"Configuration" screen ready for translations. Added a createLabel() method to UserInterfaceUtil.

@ldebello
Copy link
Contributor

Hi @chriswhocodes sending PR for "configuration" screen

#346

@chriswhocodes
Copy link
Member

Added i18n constants for the "TriView" screen. Thanks for all your hard work translators!

@ldebello
Copy link
Contributor

ldebello commented May 3, 2021

Hi @chriswhocodes sending PR for "triview" screen

#349

@gvdutra
Copy link
Contributor

gvdutra commented Nov 24, 2021

Hello, can I PR translation for portuguese? Thank you :)

@chriswhocodes
Copy link
Member

pt_BR translations now merged. Many thanks @gvdutra !

@cyberdak
Copy link
Contributor Author

cyberdak commented Jan 5, 2022

Hi @chriswhocodes ,PR for Chinese #359

@chriswhocodes
Copy link
Member

Chinese translations merged! Thanks @cyberdak :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants