Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove exp10 from 3rdparty/rnnlm/rnnlmlib.cpp #53

Open
esdeboer opened this issue Jan 5, 2020 · 2 comments
Open

remove exp10 from 3rdparty/rnnlm/rnnlmlib.cpp #53

esdeboer opened this issue Jan 5, 2020 · 2 comments

Comments

@esdeboer
Copy link
Contributor

esdeboer commented Jan 5, 2020

3rdparty/rnnlm/rnnlmlib.cpp contains the function exp10 in some logging statements.

The exp10 function is not available on freeBSD, can you remove those logging lines, or change exp10 with pow(10.0, x)?

The muse project defined their own exp10 function if missing:
muse-sequencer/muse@348d849

@AdolfVonKleist
Copy link
Owner

If you create a pull request for this, I'm happy to merge it. I don't think this bit is really used much TBH. Unless you are actively using it you could also omit it from the compilation.

@esdeboer
Copy link
Contributor Author

I created pull request #54 , the rmnllib only defined the exp10 for apple, not for the other systems not having it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants