Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to avoid user-defined restriction sites #6

Open
VittorioRainaldi opened this issue Sep 18, 2024 · 2 comments
Open

Add option to avoid user-defined restriction sites #6

VittorioRainaldi opened this issue Sep 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@VittorioRainaldi
Copy link

Hello,

for my cloning I typically use golden gate with BsaI, so it would be convenient to filter for user-defined restriction sites.

Best,
Vittorio

@Adibvafa
Copy link
Owner

Hello!
Thank you for opening an issue. That's a great suggestion, we will add non-deterministic generation with an option to find the best sequence without user-defined restriction sites. Do you have any specific list of restriction sites in mind that we can test on?

@Adibvafa Adibvafa self-assigned this Sep 19, 2024
@Adibvafa Adibvafa added the enhancement New feature or request label Sep 19, 2024
@gui11aume
Copy link
Collaborator

gui11aume commented Sep 19, 2024

This would be a feature of "forbidden" sequence that would go beyond restriction sites. If the user does not want a sequence in their construct, they should have a way to specify it. The first option is to find those sequences in the output and make the one-nucleotide change with the minimal increase in loss. The sequence would no longer be present in the output, and we would get a near-optimal encoding (optimal in terms of loss for the model). The second option is to use non-deterministic mode to produce multiple variants, sort them by loss (or likelihood, it's the same thing) and pick the top output that does not have the sequence.

We do not need a concrete set of restriction sites to get started with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants