Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.js should not be processed as TLD #44

Open
Alex-302 opened this issue Feb 20, 2023 · 1 comment
Open

.js should not be processed as TLD #44

Alex-302 opened this issue Feb 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Alex-302
Copy link
Member

Alex-302 commented Feb 20, 2023 •
edited
Loading

Sample rules from AdGuard DNS filter:

.3.n.2.1.l50.js
||113.17.188.*.js
.n.2.1.js^

Original issue: AdguardTeam/AdGuardSDNSFilter#1224
AdguardTeam/AdGuardSDNSFilter#1243
@Alex-302 Alex-302 added the bug Something isn't working label Feb 20, 2023
@DandelionSprout
Copy link
Member

DandelionSprout commented Feb 7, 2024 •
edited
Loading

In theory, the same would apply to .png, .jpg, .jpeg, .webp, .gif, .mp4, .swf, .mp3, .avi, .ogg, .flac, .mkv, and .json, but personally I'd be wary of disqualifying such entries unless they end with ^ or |, or if it's a pure domain entry that starts with a letter or number.

Of the ones above, I know I've come across at least .gif, .jpg, and swf from time to time when converting lists into DNS lists.

@Alex-302 Alex-302 mentioned this issue Feb 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alex-302 @DandelionSprout