Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent linter rule names #231

Open
scripthunter7 opened this issue Dec 19, 2024 · 0 comments
Open

Consistent linter rule names #231

scripthunter7 opened this issue Dec 19, 2024 · 0 comments
Assignees

Comments

@scripthunter7
Copy link
Member

Currently, we have the following linter rules:

if-closed
single-selector
duplicated-modifiers
unknown-preprocessor-directives
duplicated-hint-platforms
duplicated-hints
unknown-hints-and-platforms
invalid-domain-list
invalid-modifiers
inconsistent-hint-platforms
no-short-rules
no-excluded-rules
no-invalid-css-syntax
no-invalid-css-declaration

I propose making the no- prefix consistent across the rule names:

if-directive-balance
one-css-selector-per-rule
no-duplicated-modifiers
no-unknown-preprocessor-directives
no-duplicated-hint-platforms
no-duplicated-hints
no-unknown-hints-and-platforms
no-invalid-domain-list
no-invalid-modifiers
no-inconsistent-hint-platforms
no-short-rules
no-excluded-rules
no-invalid-css-syntax
no-invalid-css-declaration

In addition, it would be worthwhile to rename the if-closed rule since support for else has been added in the meantime. I also propose renaming the single-selector rule to better emphasize that it specifically refers to CSS selectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants