From bdc6b6e0289a6d939e48e00af8272d7b35ef3712 Mon Sep 17 00:00:00 2001 From: lukasnys Date: Wed, 10 Jul 2024 14:00:31 +0200 Subject: [PATCH 1/2] fix(ts): add options object with abort for onSelect fixes https://github.com/Addepar/ember-table/issues/1064 --- types/components/ember-tbody/component.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/components/ember-tbody/component.d.ts b/types/components/ember-tbody/component.d.ts index af7883366..cbb8f5633 100644 --- a/types/components/ember-tbody/component.d.ts +++ b/types/components/ember-tbody/component.d.ts @@ -78,7 +78,7 @@ export interface EmberTbodyArgs { * An action that is called when the row selection of the table changes. * Will be called with either an array or individual row, depending on the checkboxSelectionMode. */ - onSelect?: (rows: RowType[] | RowType) => void; + onSelect?: (rows: RowType[] | RowType, options: { abort: boolean }) => void; /** * A flag that tells the table to render all of its rows at once. From 75091b8624275d81eec403b632ed4960885f22e7 Mon Sep 17 00:00:00 2001 From: lukasnys Date: Wed, 20 Nov 2024 09:53:42 +0100 Subject: [PATCH 2/2] fix(ts): fix abort type to be a function --- types/components/ember-tbody/component.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/components/ember-tbody/component.d.ts b/types/components/ember-tbody/component.d.ts index cbb8f5633..9ac98c75e 100644 --- a/types/components/ember-tbody/component.d.ts +++ b/types/components/ember-tbody/component.d.ts @@ -78,7 +78,7 @@ export interface EmberTbodyArgs { * An action that is called when the row selection of the table changes. * Will be called with either an array or individual row, depending on the checkboxSelectionMode. */ - onSelect?: (rows: RowType[] | RowType, options: { abort: boolean }) => void; + onSelect?: (rows: RowType[] | RowType, options: { abort: () => void }) => void; /** * A flag that tells the table to render all of its rows at once.