Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Jenkins Wall Display Name when available #56

Open
rjrjr opened this issue Oct 5, 2016 · 3 comments
Open

Prefer Jenkins Wall Display Name when available #56

rjrjr opened this issue Oct 5, 2016 · 3 comments
Labels
CI server specific Needs help from people using this CI server help wanted Pull requests welcome service-worker Service worker (core) changes

Comments

@rjrjr
Copy link

rjrjr commented Oct 5, 2016

Our Jenkins builds have heinous proper names, so we use the Walldisplay plugin's wallDisplayname property to make them more palatable. BuildReactor doesn't seem to notice this. I haven't figured out yet where this is reported in json, I'll update when I do.

Happy to put up a PR if you could point me in the right direction.

screen shot 2016-10-04 at 5 49 43 pm

@AdamNowotny
Copy link
Owner

Looking at https://github.com/AdamNowotny/BuildReactor/blob/master/src/core/services/jenkins/jenkinsBuild.js the name should be just "displayName". Not sure if that's what the plugin uses. Can you check response from http:///job/<job_id>/api/json ?

@rjrjr rjrjr changed the title Jenkins display names aren't used Prefer Jenkins Wall Display Name when available Oct 10, 2016
@rjrjr
Copy link
Author

rjrjr commented Oct 10, 2016

Yeah, sorry about the misleading report, updated the description. This is clearly about the Walldisplay plugin. Here's the relevant bit from the api call you asked for.

  "property": [
    {},
    {
      "notifyAborted": false,
      "notifyBackToNormal": false,
      "notifyFailure": false,
      "notifyNotBuilt": false,
      "notifySuccess": false,
      "notifyUnstable": false,
      "room": "",
      "startNotification": false
    },
    {
      "notifyAborted": true,
      "notifyBackToNormal": true,
      "notifyFailure": true,
      "notifyNotBuilt": true,
      "notifySuccess": true,
      "notifyUnstable": true,
      "room": "",
      "startNotification": true
    },
    {},
    {
      "wallDisplayBgPicture": null,
      "wallDisplayName": "Nice Name Here"
    }
  ],

@AdamNowotny
Copy link
Owner

Where is the "property" field in the json tree, same level as id, url, action etc.?

@AdamNowotny AdamNowotny added help wanted Pull requests welcome CI server specific Needs help from people using this CI server and removed Jenkins labels Dec 3, 2018
@AdamNowotny AdamNowotny added the service-worker Service worker (core) changes label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI server specific Needs help from people using this CI server help wanted Pull requests welcome service-worker Service worker (core) changes
Projects
None yet
Development

No branches or pull requests

2 participants