Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logger Interface? #127

Open
AdamMc331 opened this issue Feb 20, 2024 · 2 comments
Open

Add Logger Interface? #127

AdamMc331 opened this issue Feb 20, 2024 · 2 comments
Labels
question Further information is requested

Comments

@AdamMc331
Copy link
Owner

Some folks on Twitter mentioned regularly setting up a logger (Timber is really popular in the Android space).

Given this, it might make sense to add some default logging implementation. I think it's okay if we add Timber, but I also think it might be worth putting behind a wrapper interface? This way we could also supply our own FakeLogger implementation.

Not sure if that's overkill, looking for feedback. Will put up a suggestion PR soon.
@AdamMc331 AdamMc331 added the question Further information is requested label Feb 20, 2024
@AdamMc331 AdamMc331 mentioned this issue Feb 20, 2024
Closed
@AdamMc331
Copy link
Owner Author

I'm skipping out on this for now.

@AdamMc331
Copy link
Owner Author

Reconsidering... what if all I did was add the interface? That way if you don't want to use it, you can just delete one file in particular... 🤔

@AdamMc331 AdamMc331 reopened this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AdamMc331