diff --git a/.gitignore b/.gitignore index 4e9b18359..e0da1df2d 100644 --- a/.gitignore +++ b/.gitignore @@ -138,4 +138,7 @@ dmypy.json .pytype/ # Cython debug symbols -cython_debug/ \ No newline at end of file +cython_debug/ + +# files +REMEMEBER.txt \ No newline at end of file diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..a08292638 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -30,5 +30,17 @@ def create_app(test_config=None): migrate.init_app(app, db) # Register Blueprints here + # from app.models.task import Task + from app.routes import task_bp + app.register_blueprint(task_bp) + from app.routes import goal_bp + app.register_blueprint(goal_bp) + + return app + + + + + diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..5223d97f4 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -2,4 +2,14 @@ class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + tasks = db.relationship('Task', back_populates='goals', lazy=True) + + + def to_dict(self): + goal_dict = { + "id":self.goal_id, + "title":self.title + } + return goal_dict \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..25bb4f086 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -2,4 +2,36 @@ class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, nullable=True) + is_complete = db.Column(db.Boolean, default=False) + goal_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id'), nullable = True ) + goals = db.relationship('Goal', back_populates='tasks') + + def to_dict(self): + if self.completed_at is None: + if self.goal_id is None: + task_dict = { + "id":self.id, + "title":self.title, + "description":self.description, + "is_complete": False + } + else: + task_dict = { + "id":self.id, + "goal_id": self.goal_id, + "title":self.title, + "description":self.description, + "is_complete": False + } + else: + task_dict = { + "id":self.id, + "title":self.title, + "description":self.description, + "is_complete": True + } + return task_dict \ No newline at end of file diff --git a/app/routes.py b/app/routes.py index 3aae38d49..3c18e232a 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1 +1,275 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint,jsonify, abort, make_response, request +from app import db +from app.models.task import Task +from app.models.goal import Goal +from datetime import datetime +import os +import requests + +task_bp = Blueprint("task_bp",__name__, url_prefix="/tasks") + +def get_one_task_or_abort(task_id): + try: + task_id = int(task_id) + except ValueError: + response_str = f"Invalid task_id: `{task_id}`.Id must be an integer." + abort(make_response(jsonify({'message':response_str}), 400)) + + matching_task = Task.query.get(task_id) + + if not matching_task: + response_str = f"Task with id {task_id} was not found in the database." + abort(make_response(jsonify({'message':response_str}), 404)) + return matching_task + + +@task_bp.route("", methods=["POST"]) +def add_task(): + request_body = request.get_json() + + if "title" not in request_body or \ + "description" not in request_body: + return jsonify({"details": "Invalid data"}), 400 + + new_task = Task( + title = request_body["title"], + description = request_body["description"]) + + db.session.add(new_task) + + db.session.commit() + + return { + "task":{ + "id" : new_task.id, + "title" : new_task.title, + "description" : new_task.description, + "is_complete" : new_task.is_complete + } + }, 201 + +@task_bp.route("", methods=["GET"]) +def get_all_tasks(): + title_param = request.args.get("title") + + sort_param = request.args.get("sort") + + if not title_param: + tasks = Task.query.all() + + if sort_param == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + + if sort_param == "asc": + tasks = Task.query.order_by(Task.title.asc()).all() + + response = [task.to_dict() for task in tasks] + return jsonify(response), 200 + + +@task_bp.route("/", methods=["GET"]) +def get_one_task(task_id): + chosen_task = get_one_task_or_abort(task_id) + return jsonify({"task":Task.to_dict(chosen_task)}), 200 + +@task_bp.route("/", methods=["PUT"]) +def update_one_task(task_id): + chosen_task = get_one_task_or_abort(task_id) + request_body = request.get_json() + + if "title" not in request_body or \ + "description" not in request_body: + return jsonify({"message": "Request must include title and description."}), 400 + + chosen_task.title = request_body["title"] + chosen_task.description = request_body["description"] + + db.session.commit() + + return { + "task":{ + "id" : chosen_task.id, + "title" : chosen_task.title, + "description" : chosen_task.description, + "is_complete" : chosen_task.is_complete + } + }, 200 + +@task_bp.route("/", methods=["DELETE"]) +def delete_one_task(task_id): + chosen_task = get_one_task_or_abort(task_id) + + db.session.delete(chosen_task) + + db.session.commit() + + return jsonify({"details": f'Task {task_id} "{chosen_task.title}" successfully deleted'}), 200 + + +@task_bp.route("//mark_complete", methods=["PATCH"]) +def update_is_complete(task_id): + update_is_valid_id = get_one_task_or_abort(task_id) + + update_is_valid_id.completed_at = datetime.today() + db.session.add(update_is_valid_id) + db.session.commit() + + SLACK_PATH = "https://slack.com/api/chat.postMessage" + SLACK_BOT_TOKEN = os.environ.get("SLACK_BOT_TOKEN") + + headers = { + "Authorization" : f"Bearer {SLACK_BOT_TOKEN}" + } + params = { + "channel": "task-notifications", + "text": f"Someone just completed the task {update_is_valid_id.title}" + } + + requests.get(url=SLACK_PATH, headers=headers, params=params) + + + return jsonify({"task":Task.to_dict(update_is_valid_id)}), 200 + +@task_bp.route("//mark_incomplete", methods=["PATCH"]) +def update_incompete(task_id): + task_incompete = get_one_task_or_abort(task_id) + task_incompete.completed_at = None + + db.session.add(task_incompete) + db.session.commit() + + return jsonify({"task":Task.to_dict(task_incompete)}), 200 + + +# ################################################################### +goal_bp = Blueprint("goal_bp",__name__, url_prefix="/goals") + +def get_one_goal_or_abort(id): + try: + id = int(id) + except ValueError: + response_str = f"Invalid id: `{id}`.Id must be an integer." + abort(make_response(jsonify({'message':response_str}), 400)) + + matching_goal = Goal.query.get(id) + + if not matching_goal: + response_str = f"Goal with id {id} was not found in the database." + abort(make_response(jsonify({'message':response_str}), 404)) + return matching_goal + +@goal_bp.route("", methods=["POST"]) +def add_goal(): + request_body = request.get_json() + + if "title" not in request_body: + return jsonify({"details": "Invalid data"}), 400 + + new_goal = Goal( + title = request_body["title"]) + + db.session.add(new_goal) + + db.session.commit() + + return { + "goal":{ + "id" : new_goal.goal_id, + "title" : new_goal.title + } + }, 201 + + +@goal_bp.route("", methods=["GET"]) +def get_all_goals(): + + goals = Goal.query.all() + + response = [Goal.to_dict(goal) for goal in goals] + return jsonify(response), 200 + + +@goal_bp.route("/", methods=["GET"]) +def get_one_goal(id): + chosen_goal = get_one_goal_or_abort(id) + goal_dict = { + "goal":{ + "id" : chosen_goal.goal_id, + "title" : chosen_goal.title + } + } + + return jsonify(goal_dict), 200 + +@goal_bp.route("/", methods=["PUT"]) +def update_one_task(goal_id): + chosen_goal = get_one_goal_or_abort(goal_id) + request_body = request.get_json() + + if "title" not in request_body: + return jsonify({"message": "request must include title."}), 400 + + chosen_goal.title = request_body["title"] + + db.session.commit() + + return { + "goal":{ + "id" : chosen_goal.goal_id, + "title" : chosen_goal.title + } + }, 200 + +@goal_bp.route("/", methods=["DELETE"]) +def delete_one_goal(goal_id): + chosen_goal = get_one_goal_or_abort(goal_id) + + db.session.delete(chosen_goal) + + db.session.commit() + + return jsonify({"details": f'Goal {goal_id} "{chosen_goal.title}" successfully deleted'}), 200 + +# ################################################################### + +# POST +@goal_bp.route("//tasks", methods=["POST"]) +def post_task_ids_to_goal(goal_id): + + big_goal_id = get_one_goal_or_abort(goal_id) + + request_body = request.get_json() + + for task_id in request_body["task_ids"]: + valid_task = get_one_task_or_abort(task_id) + valid_task.goals = big_goal_id + db.session.commit() + + big_goal_task_id_list = [] + for task in big_goal_id.tasks: + big_goal_task_id_list.append(task.id) + + new_goal_with_task = { + "id" : big_goal_id.goal_id, + "task_ids": big_goal_task_id_list + } + + + return jsonify(new_goal_with_task), 200 + +# # GET +@goal_bp.route("//tasks", methods=["GET"]) +def get_one_goal_with_tasks(goal_id): + chosen_big_goal_id = get_one_goal_or_abort(goal_id) + + big_goal_task_id_list = [] + for task in chosen_big_goal_id.tasks: + big_goal_task_id_list.append(Task.to_dict(task)) + + goal_dict = { + "id" : chosen_big_goal_id.goal_id, + "title" : chosen_big_goal_id.title, + "tasks": big_goal_task_id_list + } + + return jsonify(goal_dict), 200 \ No newline at end of file diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/02075f0c1a4d_.py b/migrations/versions/02075f0c1a4d_.py new file mode 100644 index 000000000..de8dfdc33 --- /dev/null +++ b/migrations/versions/02075f0c1a4d_.py @@ -0,0 +1,43 @@ +"""empty message + +Revision ID: 02075f0c1a4d +Revises: +Create Date: 2022-11-10 17:01:54.500414 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '02075f0c1a4d' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.Column('is_complete', sa.Boolean(), nullable=True), + sa.Column('goal_id', sa.Integer(), nullable=True), + sa.ForeignKeyConstraint(['goal_id'], ['goal.goal_id'], ), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index cacdbc36e..db54fe283 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,6 +5,7 @@ blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==6.5.0 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 @@ -30,5 +31,6 @@ requests==2.25.1 six==1.15.0 SQLAlchemy==1.3.23 toml==0.10.2 +tomli==2.0.1 urllib3==1.26.5 Werkzeug==1.0.1 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..f5bbd1bff 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +59,10 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +89,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +115,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +126,10 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert "message" in response_body -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +144,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +153,11 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - + assert "message" in response_body assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +174,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..05f4a9f8e 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +127,11 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert "message" in response_body == {'message': 'Task with id 1 was not found in the database.'} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +139,4 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert "message" in response_body == {'message': 'Task with id 1 was not found in the database.'} diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..f26a930c7 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ +from app.models.goal import Goal import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -28,8 +29,7 @@ def test_get_goals_one_saved_goal(client, one_goal): } ] - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +46,19 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): - pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") - # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + # raise Exception("Complete test") + # Assert + assert response.status_code == 404 + assert "message" in response_body -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +77,44 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal title" + } + } + goal = Goal.query.get(1) + assert goal.title == 'Updated Goal title' + -@pytest.mark.skip(reason="test to be completed by student") + +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + + response = client.get("/goals/1", json={ + "title": "Updated title of the goal. " + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert "message" in response_body + -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -123,28 +130,26 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + response_body = response.get_json() + assert "message" in response_body -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert "message" in response_body + assert response_body == { + "message": "Goal with id 1 was not found in the database." + } + assert Goal.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..94a5575a8 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -50,14 +50,9 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 + assert "message" in response_body - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +69,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +94,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()