-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to control hosts sources like in AdAway #8
Comments
I will introduce this feature later, that needs some time because I have to workaround the limitation Xposed brings (cannot generally read /data when module loads). But for now, I am working on other features. |
I have told where my hosts is made. You can check into the open-source licenses in app and you will see them. |
I haven't installed it yet, but I'm looking forward to test it. Anyway, list of host sources or screenshot in Readme.md would be nice. |
I think you can find it here: |
@sm4rk0 I see that this module is mainly oriented for people in China. Maybe this'll change in the future, the module is really promising. |
First, the regex list you mentioned is not only aimed at Chinese users. I use it because the regex filter can cause a lot of performance issue when there are many rules, and this is the only list which is kind of universal and short. Second, as for hosts, I am afraid thousands of lines of hosts will cause performance issue as well. I want to keep it below 2W lines and still effective. I am still searching for good hosts source with the license to use it. |
@aviraxp in that case maybe hosts file support is unnecessary functionality, because AdAway handles large hosts files just fine. You still haven't told whether root is needed for this module or not. What's wrong with license at https://github.com/StevenBlack/hosts ? |
|
@aviraxp thanks for the info. In that case maybe it would be best to have user download hosts files manually like in AdAway, if the module can handle such amount of lines. If not, leave it as is, like a bonus functionality or use root access to speed up handling hosts (I'm not sure if the latter is possible without modifying hosts file). |
Add option to control hosts sources like in AdAway or at least for now tell from which sources your hosts file is made and how often it updates.
The text was updated successfully, but these errors were encountered: