Warn when writing colored output fails.

mitchell-as · mitchell-as · commit 058c68c151f6 · 2024-12-23T14:52:15.000-05:00
Errors are sporadic and benign, but they affect automation tests, so drop the log level to warning.
diff --git a/internal/output/plain.go b/internal/output/plain.go
@@ -107,7 +107,7 @@ func (f *Plain) writeNow(writer io.Writer, value string) {
 	}
 	_, err := colorize.Colorize(value, writer, !f.cfg.Colored)
 	if err != nil {
-		logging.ErrorNoStacktrace("Writing colored output failed: %v", err)
+		logging.Warning("Writing colored output failed: %v", err)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ func (f *Plain) writeNow(writer io.Writer, value string) {`
`107`	`107`	`}`
`108`	`108`	`_, err := colorize.Colorize(value, writer, !f.cfg.Colored)`
`109`	`109`	`if err != nil {`
`110`		`- logging.ErrorNoStacktrace("Writing colored output failed: %v", err)`
	`110`	`+ logging.Warning("Writing colored output failed: %v", err)`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`