Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/38 add fixkeys command #1022

Merged
merged 40 commits into from
Jul 18, 2023
Merged

Feature/38 add fixkeys command #1022

merged 40 commits into from
Jul 18, 2023

Conversation

phjulia
Copy link
Collaborator

@phjulia phjulia commented Jul 10, 2023 •
edited by JoernBerkefeld
Loading

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via [TASK] Documentation for 5.2 #1007)

@phjulia phjulia linked an issue Jul 10, 2023 that may be closed by this pull request
add fixKeys command / CSCLSROZ-29 #38
Closed
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Jul 10, 2023
@phjulia phjulia changed the base branch from main to develop July 10, 2023 20:43
@phjulia phjulia marked this pull request as draft July 10, 2023 20:45
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited
Loading

Coverage Report

Commit:2a96380
Base: develop@9d72483

Type Base This PR
Total Statements Coverage  49.68%  50.26%  (+0.58%)
Total Branches Coverage  40.27%  41.2%  (+0.93%)
Total Functions Coverage  56.39%  56.47%  (+0.08%)
Total Lines Coverage  49.61%  50.19%  (+0.58%)
Details (changed files):
File Statements Branches Functions Lines
lib/Deployer.js  65.76%  65.34%  71.42%  66.12%
lib/cli.js  0%  0%  0%  0%
lib/index.js  53.16%  45.8%  53.84%  53.06%
lib/metadataTypes/DataExtensionField.js  58.41%  55.1%  66.66%  58%
lib/metadataTypes/MetadataType.js  66.83%  66.04%  73.25%  66.66%
lib/util/util.js  64.25%  55.29%  77.35%  64.31%

@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Jul 14, 2023
JoernBerkefeld
JoernBerkefeld requested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comments and fix failing tests

lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
JoernBerkefeld
JoernBerkefeld requested changes Jul 14, 2023
View reviewed changes
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@phjulia phjulia marked this pull request as ready for review July 14, 2023 14:52
@phjulia phjulia self-assigned this Jul 14, 2023
phjulia
phjulia commented Jul 14, 2023
View reviewed changes
test/type.query.test.js Outdated Show resolved Hide resolved
JoernBerkefeld
JoernBerkefeld requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is now good!
only waiting for documentation proposal

@JoernBerkefeld JoernBerkefeld mentioned this pull request Jul 18, 2023
Closed
@JoernBerkefeld
Copy link
Contributor

wiki entry polished and copied to #1007 for publishing

@JoernBerkefeld JoernBerkefeld merged commit b87cc86 into develop Jul 18, 2023
4 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/38-add-fixkeys-command branch July 18, 2023 08:04
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoernBerkefeld JoernBerkefeld JoernBerkefeld approved these changes

Assignees

@phjulia phjulia

Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

add fixKeys command / CSCLSROZ-29
2 participants
@phjulia @JoernBerkefeld