Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log success if Ctrl-C in the middle of the execution #3

Open
bo-abstrlabs opened this issue Apr 29, 2022 · 1 comment
Open

Log success if Ctrl-C in the middle of the execution #3

bo-abstrlabs opened this issue Apr 29, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bo-abstrlabs
Copy link
Member

If it's not interrupted by Ctrl-C, the result is failing:

priceprover (main) priceprover submit
2022-04-29 11:12:41 INFO  CommandExecutor:53 - Submit price and proof to chain start
2022-04-29 11:12:42 ERROR CommandExecutor:30 - Submit price and proof to chain failed
2022-04-29 11:12:42 ERROR CommandExecutor:31 - Error ABLDR410: status_code=400,
2022-04-29 11:12:42 ERROR CommandExecutor:34 - TransactionPool.Remember: transaction 3FNHS6JCSJAV7MGKLSOVO7KTE7NZRKQJGEOS32GOY5BZRZBH5CSQ: logic eval error: err opcode executed. Details: pc=718, opcodes===
2022-04-29 11:12:42 ERROR CommandExecutor:34 - bnz label8
2022-04-29 11:12:42 ERROR CommandExecutor:34 - err
2022-04-29 11:12:42 ERROR CommandExecutor:34 - label8:
2022-04-29 11:12:42 ERROR CommandExecutor:34 - 
2022-04-29 11:12:42 ERROR CommandExecutor:34 - context={"scriptPath":"scripts/call-verify.js"}
2022-04-29 11:12:42 ERROR CommandExecutor:34 - For more info run algob with --show-stack-traces or add --help to display task-specific help.

But it's logging as success when Ctrl-C immediately:

priceprover (main) priceprover submit
2022-04-29 11:12:24 INFO  CommandExecutor:53 - Submit price and proof to chain start
^C2022-04-29 11:12:25 INFO  CommandExecutor:38 - Submit price and proof to chain successfully
2022-04-29 11:12:25 INFO  TransactionSubmitter:40 - Proof validated by zkp_verifier. Submit success

Exit code in this case was 130, which is correct, so just the logging issue. Maybe the same issue as #2

@bo-abstrlabs bo-abstrlabs added the bug Something isn't working label May 8, 2022
@Ryuya1995
Copy link
Contributor

Add an validation mechanism for input/output files for command execution:
d520eef

The actual fix will be made by update all command.excute to include this validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants