Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test typing with mypy in CI #41

Open
MattijsKneppers opened this issue Jul 8, 2024 · 3 comments
Open

Test typing with mypy in CI #41

MattijsKneppers opened this issue Jul 8, 2024 · 3 comments
Assignees
@jby-ableton

Comments

@MattijsKneppers
Copy link
Contributor

Flake8 is generally used by Ableton for python type checks
@ala-ableton
Copy link

AFAIK, flake8 doesn't do type checking.

@MattijsKneppers
Copy link
Contributor Author

Wait, you're right of course, flake8 is only used for style checking! I misread the Python guide article in Ableton's software engineering practices. Never mind then @jby-ableton , seems like we can stick to mypy.

@MattijsKneppers MattijsKneppers changed the title Consider switching to flake8 for type checking and add a test to CI Test typing with mypy in CI Jul 11, 2024
@MattijsKneppers
Copy link
Contributor Author

I rephrased the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jby-ableton jby-ableton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MattijsKneppers @ala-ableton @jby-ableton