Unit tests

[gllmflndn]

Hi @Abdallah-Elshamy

Thanks for the comprehensive list of unit tests. They highlighted one difference between JSONio and jsonencode/jsondecode (test 22: b = instead of b = ) that I was not aware of.

Concerning the other points mentioned on the maintainers mailing list, for JSONio, I have added some extra options, Indent and ReplacementStyle, defaulting to Matlab. Perhaps a similar approach could be taken for Octave?

[Abdallah-Elshamy]

Hello @gllmflndn

I am glad that the unit tests were helpful to you.

A human-readable format ("pretty" indentation) for JSON is already on the list for jsonencode. Adding a style for replacement is a good idea and I will discuss it with the community before writing jsonencode. Thanks for mentioning that.

[siko1056]

The ReplacementStyle option is described for JSONio here

https://github.com/gllmflndn/JSONio/blob/6c699a315ac2c578864d8b740a061bff47b718bf/jsonread.m#L6-L9

and for Matlab matlab.lang.makeValidName here

https://www.mathworks.com/help/matlab/ref/matlab.lang.makevalidname.html#namevaluepairarguments

and might be a nice addition to cope with non-alphanumeric characters. The following works in Octave, but is considered as "invalid fieldname" in Matlab R2020b:

>> struct ("4number!", 3.14)
ans =

  scalar structure containing the fields:

    4number! = 3.1400

@Abdallah-Elshamy your jsondecode.cc currently follows Matlab

>> jsondecode ('{"4number!": 3.14}')
ans =

  scalar structure containing the fields:

    x4number_ = 3.1400

So the big idea is to just forward jsondecode (..., "ReplacementStyle", style) to matlab.lang.makeValidName

https://github.com/Abdallah-Elshamy/octave/blob/933e6ff0b47fb85e7cbe72b30bcd1660eb86deff/libinterp/corefcn/jsondecode.cc#L68-L71

Sounds good to me. Maybe you can also implement jsondecode (..., "Prefix", prefix) by forwarding varargin {2:end} to matlab.lang.makeValidName. This way we can also fix leading numbers in struct keys, like in the example above.

https://www.mathworks.com/help/matlab/ref/matlab.lang.makevalidname.html#namevaluepairarguments

[Abdallah-Elshamy]

Hi,

I have added the "ReplacementStyle" and "Prefix" options here in 7b96f44. I followed the suggested idea and forwarded the options to matlab.lang.makeValidName.

If you have any comments, please let me know

[Abdallah-Elshamy]

Hello all,

I added the "PrettyWriter" option in 3c75468. I also added the "ReplacementStyle" and "Prefix" options here in 27c37af.

If there is any other suggestions or comments, please let me know.
Thanks for your suggestions.