From b51945b467fd2213351023d3d95d9cfe779f4a14 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Wed, 17 Jan 2024 17:16:47 -0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Aaron Robinson --- src/dnmd/entry.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/dnmd/entry.c b/src/dnmd/entry.c index a43ac0f4..c0fd29ba 100644 --- a/src/dnmd/entry.c +++ b/src/dnmd/entry.c @@ -268,9 +268,11 @@ static bool initialize_minimal_table_rows(mdcxt_t* cxt) if (1 != set_column_value_as_heap_offset(module_cursor, mdtModule_Mvid, 1, &guid_heap_offset) || 1 != set_column_value_as_heap_offset(module_cursor, mdtModule_EncBaseId, 1, &guid_heap_offset) || 1 != set_column_value_as_heap_offset(module_cursor, mdtModule_EncId, 1, &guid_heap_offset)) + { return false; + } - const char* name = ""; + char const* name = ""; if (1 != md_set_column_value_as_utf8(module_cursor, mdtModule_Name, 1, &name)) return false; @@ -284,7 +286,7 @@ static bool initialize_minimal_table_rows(mdcxt_t* cxt) if (1 != md_set_column_value_as_constant(global_type_cursor, mdtTypeDef_Flags, 1, &flags)) return false; - const char* global_type_name = ""; + char const* global_type_name = ""; // Defined in ECMA-335 II.10.8 if (1 != md_set_column_value_as_utf8(global_type_cursor, mdtTypeDef_TypeName, 1, &global_type_name)) return false; @@ -330,7 +332,6 @@ mdhandle_t md_create_new_handle() return pcxt; } - bool md_apply_delta(mdhandle_t handle, void const* data, size_t data_len) { mdcxt_t* base = extract_mdcxt(handle);