Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Cleanup of "dead code" #338

Open
BanjoFox opened this issue Oct 11, 2024 · 3 comments
Open

TODO: Cleanup of "dead code" #338

BanjoFox opened this issue Oct 11, 2024 · 3 comments
Assignees

Comments

@BanjoFox
Copy link
Collaborator

Using VS Code and the rust-analyzer extension there are numerous "dead code", and "unused import" warnings being detected.
Resolving these will not only help to implement functionality, but will also go a long way towards cleaning up the visual clutter when running tests and builds.

There may be instances, such as 'id' and 'csrf', where implementing a "TODO" function would be acceptable for the interim.
On the other hand there are still numerous uses of e when it comes to error handling which should be implemented sooner than later.

@jakerogers-1
Copy link

Hi! I'd love to take a shot at this.

@BanjoFox
Copy link
Collaborator Author

Have at!

Almost everything that I have seen so far had a purpose when originally written. If that purpose is not immediately apparent, or easy to implement then create a way for future devs to quickly identify it :)

@BanjoFox
Copy link
Collaborator Author

Oh, and it is not necessary to fix all of it in one go. Some of that functionality could/should be split out into other tasks.

@BanjoFox BanjoFox changed the title Cleanup of "dead code" TODO: Cleanup of "dead code" Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants